mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Neil Brown <neilb@cse.unsw.edu.au>
To: "Randy.Dunlap" <rddunlap@osdl.org>
Cc: lkml <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] exportfs: reduce stack usage
Date: Fri, 1 Oct 2004 11:12:28 +1000	[thread overview]
Message-ID: <16732.44796.86341.578389@cse.unsw.edu.au> (raw)
In-Reply-To: message from Randy.Dunlap on Tuesday September 28

On Tuesday September 28, rddunlap@osdl.org wrote:
> 
> find_exported_dentry() declares
> 	char nbuf[NAME_MAX+1];
> in 2 separate places, and gcc allocates space on the stack for both
> of them.  Having just one of them will suffice, if we can put put
> with its scope.
> 
> Reduces function stack usage on x86-32 from 0x230 to 0x130.

So it does.  I thought gcc was cleverer than that.
I'll add it to my collection.

Thanks,
NeilBrown

      reply	other threads:[~2004-10-01  1:12 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2004-09-29  4:57 Randy.Dunlap
2004-10-01  1:12 ` Neil Brown [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=16732.44796.86341.578389@cse.unsw.edu.au \
    --to=neilb@cse.unsw.edu.au \
    --cc=linux-kernel@vger.kernel.org \
    --cc=rddunlap@osdl.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®