From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 65E00C46467 for ; Mon, 16 Jan 2023 16:36:15 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S233490AbjAPQgN (ORCPT ); Mon, 16 Jan 2023 11:36:13 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:52714 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S233038AbjAPQfx (ORCPT ); Mon, 16 Jan 2023 11:35:53 -0500 Received: from ams.source.kernel.org (ams.source.kernel.org [145.40.68.75]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 9590F30EA7; Mon, 16 Jan 2023 08:24:06 -0800 (PST) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ams.source.kernel.org (Postfix) with ESMTPS id 4902FB81065; Mon, 16 Jan 2023 16:24:05 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 705F2C433F1; Mon, 16 Jan 2023 16:24:01 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1673886244; bh=Xa4zXDzPxuSD1mCwh5IIhSowSMlMbPBGb/rtmYiebas=; h=Subject:From:In-Reply-To:References:To:Cc:Date:From; b=WXwjYVnbosQ1VJJhJrleDAHRCqHh1veZTk6xuE7/uy6CythCGIrKTsIVdVasrrgvu niilM4/tp7llmASXnxH+EV5eeIK/1r+V995ZVTtD8s2MBPAdsKjxN0m3VQxirM61zU 6ekDcfUu2yivuQWacrymNjyounhrLfBpvgs/UyFomcB2OwwHa2OTrZ80LBTK7SNhBe xTbXnddsHb9+OAHRpkrS0vu2L+NoLeeIdLMHfJKqFIXD7pTxkX0rzY7LcM/kjKyMT5 4LQGhBxOWoJWg9EJWmKqBBc0fifM9fs55aBIRnUKdQb+uFoIlpc0ek0VwFz8h3pAND wSuqDeKesS5hg== Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Subject: Re: [PATCH v2] wifi: rt2x00: Remove useless else if From: Kalle Valo In-Reply-To: <20230106022731.111243-1-jiapeng.chong@linux.alibaba.com> References: <20230106022731.111243-1-jiapeng.chong@linux.alibaba.com> To: Jiapeng Chong Cc: stf_xl@wp.pl, helmut.schaa@googlemail.com, davem@davemloft.net, edumazet@google.com, kuba@kernel.org, pabeni@redhat.com, linux-wireless@vger.kernel.org, netdev@vger.kernel.org, linux-kernel@vger.kernel.org, Jiapeng Chong , Abaci Robot User-Agent: pwcli/0.1.1-git (https://github.com/kvalo/pwcli/) Python/3.7.3 Message-ID: <167388623942.5321.8431065442138350705.kvalo@kernel.org> Date: Mon, 16 Jan 2023 16:24:01 +0000 (UTC) Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Jiapeng Chong wrote: > The assignment of the else and else if branches is the same, so the else > if here is redundant, so we remove it. > > ./drivers/net/wireless/ralink/rt2x00/rt2800lib.c:8927:9-11: WARNING: > possible condition with no effect (if == else). > > Link: https://bugzilla.openanolis.cn/show_bug.cgi?id=3631 > Reported-by: Abaci Robot > Signed-off-by: Jiapeng Chong > Acked-by: Stanislaw Gruszka Patch applied to wireless-next.git, thanks. ebe8dee7aea6 wifi: rt2x00: Remove useless else if -- https://patchwork.kernel.org/project/linux-wireless/patch/20230106022731.111243-1-jiapeng.chong@linux.alibaba.com/ https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches