mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Byungchul Park <byungchul.park@lge.com>
To: hdanton@sina.com
Cc: linux-kernel@vger.kernel.org, linux-mm@kvack.org,
	torvalds@linux-foundation.org, longman@redhat.com,
	penguin-kernel@I-love.SAKURA.ne.jp, max.byungchul.park@gmail.com
Subject: Re: [PATCH RFC v7 08/23] dept: Apply sdt_might_sleep_strong() to PG_{locked,writeback} wait
Date: Thu, 19 Jan 2023 10:38:34 +0900	[thread overview]
Message-ID: <1674092314-16409-1-git-send-email-byungchul.park@lge.com> (raw)
In-Reply-To: <20230109113720.221-1-hdanton@sina.com>

Hillf wrote:
> On 9 Jan 2023 12:33:36 +0900 Byungchul Park <byungchul.park@lge.com>
>> Makes Dept able to track dependencies by PG_{locked,writeback} waits.
>> 
>> Signed-off-by: Byungchul Park <byungchul.park@lge.com>
>> ---
> 
> Hey Byungchul 

+cc max.byungchul.park@gmail.com

Hi,

This email never reached to me.

> Is DEPT able to get deadlock reported for the syzbot report [1]?

DEPT can detect the case 100% *IF* the folio_trylock() is released
within the same context since DEPT tracks folio_trylock(), folio_lock()
and folio_unlock(), and it's definitely a deadlock.

But as we know, because folio_trylock() can be released by another
context like irq, it might be either just a severe slowdown of the
context triggering folio_unlock() or a literal deadlock where the
context is involved. I dunno which one is the case.

In short, DEPT can detect this case too *IF* it's a literal deadlock,
but it doesn't if it's just a slowdown. I'm planning to warn it even if
there is a slowdown tho, not for now.

Let me reproduce the following issue. I will share the result.

> Hillf
> 
> [1] https://lore.kernel.org/lkml/6383cde5-cf4b-facf-6e07-1378a485657d@I-love.SAKURA.ne.jp/

	Byungchul

       reply	other threads:[~2023-01-19  1:48 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <20230109113720.221-1-hdanton@sina.com>
2023-01-19  1:38 ` Byungchul Park [this message]
2023-01-21  3:35   ` Byungchul Park
2023-01-09  3:33 [PATCH RFC v7 00/23] DEPT(Dependency Tracker) Byungchul Park
2023-01-09  3:33 ` [PATCH RFC v7 08/23] dept: Apply sdt_might_sleep_strong() to PG_{locked,writeback} wait Byungchul Park
2023-01-09  9:10   ` Sergey Shtylyov

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1674092314-16409-1-git-send-email-byungchul.park@lge.com \
    --to=byungchul.park@lge.com \
    --cc=hdanton@sina.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-mm@kvack.org \
    --cc=longman@redhat.com \
    --cc=max.byungchul.park@gmail.com \
    --cc=penguin-kernel@I-love.SAKURA.ne.jp \
    --cc=torvalds@linux-foundation.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®