From: Rob Herring <robh@kernel.org>
To: Bryan O'Donoghue <bryan.odonoghue@linaro.org>
Cc: devicetree@vger.kernel.org, krzysztof.kozlowski+dt@linaro.org,
linux-arm-msm@vger.kernel.org, konrad.dybcio@linaro.org,
linux-kernel@vger.kernel.org, benl@squareup.com,
linux-pm@vger.kernel.org, robh+dt@kernel.org,
stephan@gerhold.net, agross@kernel.org, djakov@kernel.org,
shawn.guo@linaro.org, fabien.parent@linaro.org,
dmitry.baryshkov@linaro.org, leo.yan@linaro.org,
andersson@kernel.org
Subject: Re: [PATCH v4 1/6] dt-bindings: clock: msm8939: Move msm8939 to a distinct yaml file
Date: Mon, 23 Jan 2023 07:49:02 -0600 [thread overview]
Message-ID: <167448142490.1341243.15159926410174126977.robh@kernel.org> (raw)
In-Reply-To: <20230123023127.1186619-2-bryan.odonoghue@linaro.org>
On Mon, 23 Jan 2023 02:31:22 +0000, Bryan O'Donoghue wrote:
> The MSM8939 has two DSI controllers as opposed to the MSM8916 which has
> one. As a consequence we need to document some additional clocks provided
> by the MSM8939 GCC which are not provided by MSM8916.
>
> Move the declaration of the MSM8939 super-set of clocks to an MSM8939
> specific yaml file.
>
> Signed-off-by: Bryan O'Donoghue <bryan.odonoghue@linaro.org>
> ---
> .../bindings/clock/qcom,gcc-msm8916.yaml | 7 +-
> .../bindings/clock/qcom,gcc-msm8939.yaml | 87 +++++++++++++++++++
> 2 files changed, 89 insertions(+), 5 deletions(-)
> create mode 100644 Documentation/devicetree/bindings/clock/qcom,gcc-msm8939.yaml
>
My bot found errors running 'make DT_CHECKER_FLAGS=-m dt_binding_check'
on your patch (DT_CHECKER_FLAGS is new in v5.13):
yamllint warnings/errors:
dtschema/dtc warnings/errors:
Documentation/devicetree/bindings/clock/qcom,gcc-msm8939.example.dts:18:18: fatal error: dt-bindings/clock/qcom,rpm.h: No such file or directory
18 | #include <dt-bindings/clock/qcom,rpm.h>
| ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
compilation terminated.
make[1]: *** [scripts/Makefile.lib:434: Documentation/devicetree/bindings/clock/qcom,gcc-msm8939.example.dtb] Error 1
make[1]: *** Waiting for unfinished jobs....
make: *** [Makefile:1508: dt_binding_check] Error 2
doc reference errors (make refcheckdocs):
See https://patchwork.ozlabs.org/project/devicetree-bindings/patch/20230123023127.1186619-2-bryan.odonoghue@linaro.org
The base for the series is generally the latest rc1. A different dependency
should be noted in *this* patch.
If you already ran 'make dt_binding_check' and didn't see the above
error(s), then make sure 'yamllint' is installed and dt-schema is up to
date:
pip3 install dtschema --upgrade
Please check and re-submit after running the above command yourself. Note
that DT_SCHEMA_FILES can be set to your schema file to speed up checking
your schema. However, it must be unset to test all examples with your schema.
next prev parent reply other threads:[~2023-01-23 13:49 UTC|newest]
Thread overview: 29+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-01-23 2:31 [PATCH v4 0/6] Add MSM8939 SoC support with two devices Bryan O'Donoghue
2023-01-23 2:31 ` [PATCH v4 1/6] dt-bindings: clock: msm8939: Move msm8939 to a distinct yaml file Bryan O'Donoghue
2023-01-23 9:06 ` Krzysztof Kozlowski
2023-01-23 13:49 ` Rob Herring [this message]
2023-01-23 2:31 ` [PATCH v4 2/6] dt-bindings: interconnect: Exclude all non msm8939 from snoc-mm Bryan O'Donoghue
2023-01-23 2:31 ` [PATCH v4 3/6] arm64: dts: qcom: Add msm8939 SoC Bryan O'Donoghue
2023-01-23 2:31 ` [PATCH v4 4/6] arm64: dts: qcom: Add msm8939-pm8916.dtsi include Bryan O'Donoghue
2023-01-23 2:31 ` [PATCH v4 5/6] arm64: dts: qcom: Add Square apq8039-t2 board Bryan O'Donoghue
2023-01-23 16:17 ` Konrad Dybcio
2023-01-23 16:29 ` Krzysztof Kozlowski
2023-01-25 1:21 ` Bryan O'Donoghue
2023-01-25 1:29 ` Konrad Dybcio
2023-01-25 2:25 ` Bryan O'Donoghue
2023-01-25 7:15 ` Krzysztof Kozlowski
2023-01-23 2:31 ` [PATCH v4 6/6] arm64: dts: qcom: Add msm8939 Sony Xperia M4 Aqua Bryan O'Donoghue
2023-01-23 16:19 ` Konrad Dybcio
2023-01-23 11:00 ` [PATCH v4 0/6] Add MSM8939 SoC support with two devices Bryan O'Donoghue
2023-01-23 11:08 ` Bryan O'Donoghue
2023-01-23 12:49 ` Stephan Gerhold
2023-01-23 13:03 ` Bryan O'Donoghue
2023-01-23 13:23 ` Bryan O'Donoghue
2023-01-23 14:00 ` Stephan Gerhold
2023-01-23 16:14 ` Bryan O'Donoghue
2023-01-23 16:21 ` Konrad Dybcio
2023-01-23 16:29 ` Bryan O'Donoghue
2023-01-26 15:29 ` Bryan O'Donoghue
2023-01-26 15:34 ` Konrad Dybcio
2023-01-26 16:32 ` Bryan O'Donoghue
2023-01-26 16:45 ` Bryan O'Donoghue
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=167448142490.1341243.15159926410174126977.robh@kernel.org \
--to=robh@kernel.org \
--cc=agross@kernel.org \
--cc=andersson@kernel.org \
--cc=benl@squareup.com \
--cc=bryan.odonoghue@linaro.org \
--cc=devicetree@vger.kernel.org \
--cc=djakov@kernel.org \
--cc=dmitry.baryshkov@linaro.org \
--cc=fabien.parent@linaro.org \
--cc=konrad.dybcio@linaro.org \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=leo.yan@linaro.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pm@vger.kernel.org \
--cc=robh+dt@kernel.org \
--cc=shawn.guo@linaro.org \
--cc=stephan@gerhold.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®