From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 36174C433F5 for ; Tue, 12 Apr 2022 12:53:35 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1354675AbiDLMzu (ORCPT ); Tue, 12 Apr 2022 08:55:50 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:34148 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1355838AbiDLMsh (ORCPT ); Tue, 12 Apr 2022 08:48:37 -0400 Received: from mail-ej1-x631.google.com (mail-ej1-x631.google.com [IPv6:2a00:1450:4864:20::631]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 7A0D63DA73 for ; Tue, 12 Apr 2022 05:19:40 -0700 (PDT) Received: by mail-ej1-x631.google.com with SMTP id p15so36942843ejc.7 for ; Tue, 12 Apr 2022 05:19:40 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=message-id:date:mime-version:user-agent:subject:content-language:to :references:from:in-reply-to:content-transfer-encoding; bh=B9+cI4IoL52revKm+mDw49Lnf0IFiGCiBvB1l4R4Zhs=; b=A6ZS7Z8yI1gNu2iwhHBbnSZ0QbwqlDVmSlNIgYrboFMCpplzOT5VRWB6uCvnftD4ED rA9JU84nd4w1lZ87TUCdGOodAaN/hWWeUmGfOWIikMdV2c6IrLSBBnSZGy9pETQxfNpv rEpYrUjQ3oi2z2VRoXouRjXsigMtkrGChaDBcTNBMnK74w713fbtoc/HFrb9RX1i7eEe TUsREoOo/BgbPe9u7sk1tsBXmY6a6VGYE0Yv5/t9mA9o7vClx/OIL7TxOg1qqDZNuRiJ 47btEH27lFwN0nUpE2/xnkKki+WPoQt3EVRqd240hjir6hDDUH32RepsJNlVe395oYTD X+wg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:message-id:date:mime-version:user-agent:subject :content-language:to:references:from:in-reply-to :content-transfer-encoding; bh=B9+cI4IoL52revKm+mDw49Lnf0IFiGCiBvB1l4R4Zhs=; b=5HasDRbwoJ+2cp5LG/L/HYSr4EUBosD3QYZgv6pEcqe2PVZGlxiovQQI2rgI5Uw6Lh /RVBgOgOkigVGF58vp/+Ykd4JgPsKZBcQK4jiib4SpLPWVdwBjicc3M1fRbmmUixng/J mEKvBLjnAiOh099kDqhMi/FvP0eALOYfK6NpRUOQherX8hj1sHlExRfir3kKswkInr7x Jj4EK4C9/2uP+e4+aPVvVHrDFrV3ClhbandEdh87pW3umlhX5fi9PttMYRBBGbQk1S6+ ZoBCh0E2/pfO9QcTFTJ3n936bvCeDsXKd+MFXYiBwEdddwRwtaq+5rbxWHkRCgnF+flK IHFA== X-Gm-Message-State: AOAM530kmGXmTIDPkwyDDQm6QDRn4JbzRU+v3PCeQQGfFEYwkPvSuaJe WeQ/QdT2tT+ibnVNY+0rgJlgQA== X-Google-Smtp-Source: ABdhPJxP5FPJxSzsun3ev7AJry3+ba7d3iA+/B0jezlSiH093DYefWri2aUuJXT5chMPrfaGPZCtxQ== X-Received: by 2002:a17:906:7307:b0:6da:92e1:9c83 with SMTP id di7-20020a170906730700b006da92e19c83mr34466390ejc.459.1649765978985; Tue, 12 Apr 2022 05:19:38 -0700 (PDT) Received: from [192.168.0.195] (xdsl-188-155-201-27.adslplus.ch. [188.155.201.27]) by smtp.gmail.com with ESMTPSA id g14-20020a50e04e000000b0041cd8db541fsm12509112edl.74.2022.04.12.05.19.38 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 12 Apr 2022 05:19:38 -0700 (PDT) Message-ID: <16750a7d-de4b-0bba-9513-c45560d279ba@linaro.org> Date: Tue, 12 Apr 2022 14:19:37 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.7.0 Subject: Re: [PATCH] memory: renesas-rpc-if: Simplify single/double data register access Content-Language: en-US To: Wolfram Sang , Geert Uytterhoeven , Sergey Shtylyov , Duc Nguyen , Lad Prabhakar , Andrew Gabbasov , Linux-Renesas , MTD Maling List , Linux Kernel Mailing List References: <19358863deae03b1b26f473e878305a1c6e40d19.1649681638.git.geert+renesas@glider.be> From: Krzysztof Kozlowski In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 12/04/2022 12:17, Wolfram Sang wrote: > >> But that's not what happened. I even compared the assembler output of >> various solutions. > > I am sure you did. I just said "it looks like..." to state a reason why > I don't think it looks prettier. But this turns to bike-shedding for me, > just keep it if everyone else is happy. I vote for removal of ++, because later someone might wonder why it was incremented even if not used. Best regards, Krzysztof