From: Bjorn Andersson <andersson@kernel.org>
To: agross@kernel.org, Tom Rix <trix@redhat.com>, konrad.dybcio@linaro.org
Cc: linux-kernel@vger.kernel.org, linux-arm-msm@vger.kernel.org
Subject: Re: [PATCH] soc: qcom: pmic_glink: remove redundant calculation of svid
Date: Mon, 6 Feb 2023 14:30:39 -0800 [thread overview]
Message-ID: <167572263441.3569822.2330094320781179275.b4-ty@kernel.org> (raw)
In-Reply-To: <20230206135831.1794583-1-trix@redhat.com>
On Mon, 6 Feb 2023 05:58:31 -0800, Tom Rix wrote:
> gcc with W=1 reports
> drivers/soc/qcom/pmic_glink_altmode.c:223:13: error: variable ‘svid’ set but not used [-Werror=unused-but-set-variable]
> 223 | u16 svid;
>
> From reviewing the code, the setting of alt_port->svid does the same calculation.
> Both are not needed. For debuggablity, keep the setting of local svid.
>
> [...]
Applied, thanks!
[1/1] soc: qcom: pmic_glink: remove redundant calculation of svid
commit: dcb4e7a57cbe8d85e4927f517ae28aab17596419
Best regards,
--
Bjorn Andersson <andersson@kernel.org>
prev parent reply other threads:[~2023-02-06 22:29 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-02-06 13:58 Tom Rix
2023-02-06 22:30 ` Bjorn Andersson [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=167572263441.3569822.2330094320781179275.b4-ty@kernel.org \
--to=andersson@kernel.org \
--cc=agross@kernel.org \
--cc=konrad.dybcio@linaro.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=trix@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®