From: Rob Herring <robh@kernel.org>
To: Yong Wu <yong.wu@mediatek.com>
Cc: Tiffany Lin <tiffany.lin@mediatek.com>,
linux-media@vger.kernel.org,
kyrie wu <kyrie.wu@mediatek.corp-partner.google.com>,
youlin.pei@mediatek.com,
Matthias Brugger <matthias.bgg@gmail.com>,
Will Deacon <will@kernel.org>, Hans Verkuil <hverkuil@xs4all.nl>,
Mauro Carvalho Chehab <mchehab@kernel.org>,
Robin Murphy <robin.murphy@arm.com>,
Andrew-CT Chen <andrew-ct.chen@mediatek.com>,
chengci.xu@mediatek.com, mingyuan.ma@mediatek.com,
devicetree@vger.kernel.org, Joerg Roedel <joro@8bytes.org>,
linux-arm-kernel@lists.infradead.org, anan.sun@mediatek.com,
iommu@lists.linux.dev, libo.kang@mediatek.com,
Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
yf.wang@mediatek.com,
AngeloGioacchino Del Regno
<angelogioacchino.delregno@collabora.com>,
linux-mediatek@lists.infradead.org, nfraprado@collabora.com,
Rob Herring <robh+dt@kernel.org>,
linux-kernel@vger.kernel.org,
Yunfei Dong <yunfei.dong@mediatek.com>
Subject: Re: [PATCH v2 01/10] dt-bindings: media: mediatek,vcodec: Remove dma-ranges property
Date: Thu, 9 Feb 2023 11:43:08 -0600 [thread overview]
Message-ID: <167596458765.553111.2698863120254622830.robh@kernel.org> (raw)
In-Reply-To: <20230208053643.28249-2-yong.wu@mediatek.com>
On Wed, 08 Feb 2023 13:36:34 +0800, Yong Wu wrote:
> After commit f1ad5338a4d5 ("of: Fix "dma-ranges" handling for bus
> controllers"), the dma-ranges of the leaf node doesn't work. Remove
> it for vcodec here.
>
> 1) For mediatek,vcodec-decoder.yaml and mediatek,vcodec-encoder.yaml,
> this property is in the leaf node, it is invalid as the above comment.
>
> Currently there is only mt8195 VENC node has this property in upstream.
> Indeed, VENC is affected, but it is not a fatal issue. Originally it
> expects its iova range locate at 4GB-8GB. However after that commit, its
> expectation doesn't come true, it will fall back to 0-4GB iova and also
> could work well.
>
> 2) For mediatek,vcodec-subdev-decoder.yaml, It already uses parent-child
> node, this property works. Instead, MediaTek iommu will control the
> masters' iova ranges by the master's larb/port id internally, then the
> dma-ranges property is unnecessary for the master's node.
>
> Cc: Tiffany Lin <tiffany.lin@mediatek.com>
> Cc: Andrew-CT Chen <andrew-ct.chen@mediatek.com>
> Cc: Yunfei Dong <yunfei.dong@mediatek.com>
> Cc: Mauro Carvalho Chehab <mchehab@kernel.org>
> Cc: Matthias Brugger <matthias.bgg@gmail.com>
> Signed-off-by: Yong Wu <yong.wu@mediatek.com>
> Reviewed-by: AngeloGioacchino Del Regno <angelogioacchino.delregno@collabora.com>
> ---
> .../devicetree/bindings/media/mediatek,vcodec-decoder.yaml | 5 -----
> .../devicetree/bindings/media/mediatek,vcodec-encoder.yaml | 5 -----
> .../bindings/media/mediatek,vcodec-subdev-decoder.yaml | 7 -------
> 3 files changed, 17 deletions(-)
>
Acked-by: Rob Herring <robh@kernel.org>
next prev parent reply other threads:[~2023-02-09 17:43 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-02-08 5:36 [PATCH v2 00/10] Adjust the dma-ranges for MTK IOMMU Yong Wu
2023-02-08 5:36 ` [PATCH v2 01/10] dt-bindings: media: mediatek,vcodec: Remove dma-ranges property Yong Wu
2023-02-09 17:43 ` Rob Herring [this message]
2023-02-08 5:36 ` [PATCH v2 02/10] dt-bindings: media: mediatek,jpeg: " Yong Wu
2023-02-09 17:45 ` Rob Herring
2023-02-08 5:36 ` [PATCH v2 03/10] iommu/mediatek: Get regionid from larb/port id Yong Wu
2023-02-09 13:39 ` AngeloGioacchino Del Regno
2023-02-10 6:13 ` Yong Wu (吴勇)
2023-02-08 5:36 ` [PATCH v2 04/10] iommu/mediatek: mt8195: Add larb_region_msk Yong Wu
2023-02-08 5:36 ` [PATCH v2 05/10] iommu/mediatek: mt8186: add larb_region_msk Yong Wu
2023-02-08 5:36 ` [PATCH v2 06/10] iommu/mediatek: mt8192: " Yong Wu
2023-02-08 5:36 ` [PATCH v2 07/10] iommu/mediatek: Add a gap for the iova regions Yong Wu
2023-02-08 5:36 ` [PATCH v2 08/10] arm64: dts: mt8195: Add dma-ranges for the parent "soc" node Yong Wu
2023-02-08 5:36 ` [PATCH v2 09/10] arm64: dts: mt8195: Remove the unnecessary dma-ranges Yong Wu
2023-02-08 5:36 ` [PATCH v2 10/10] arm64: dts: mt8186: Add dma-ranges for the parent "soc" node Yong Wu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=167596458765.553111.2698863120254622830.robh@kernel.org \
--to=robh@kernel.org \
--cc=anan.sun@mediatek.com \
--cc=andrew-ct.chen@mediatek.com \
--cc=angelogioacchino.delregno@collabora.com \
--cc=chengci.xu@mediatek.com \
--cc=devicetree@vger.kernel.org \
--cc=hverkuil@xs4all.nl \
--cc=iommu@lists.linux.dev \
--cc=joro@8bytes.org \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=kyrie.wu@mediatek.corp-partner.google.com \
--cc=libo.kang@mediatek.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-media@vger.kernel.org \
--cc=linux-mediatek@lists.infradead.org \
--cc=matthias.bgg@gmail.com \
--cc=mchehab@kernel.org \
--cc=mingyuan.ma@mediatek.com \
--cc=nfraprado@collabora.com \
--cc=robh+dt@kernel.org \
--cc=robin.murphy@arm.com \
--cc=tiffany.lin@mediatek.com \
--cc=will@kernel.org \
--cc=yf.wang@mediatek.com \
--cc=yong.wu@mediatek.com \
--cc=youlin.pei@mediatek.com \
--cc=yunfei.dong@mediatek.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®