From: Jens Axboe <axboe@kernel.dk>
To: Ming Lei <ming.lei@redhat.com>, Liu Xiaodong <xiaodong.liu@intel.com>
Cc: linux-block@vger.kernel.org, linux-kernel@vger.kernel.org,
Jim Harris <james.r.harris@intel.com>
Subject: Re: [PATCH] block: ublk: check IO buffer based on flag need_get_data
Date: Mon, 13 Feb 2023 08:36:50 -0700 [thread overview]
Message-ID: <167630261065.98786.1863973416590406572.b4-ty@kernel.dk> (raw)
In-Reply-To: <20230210141356.112321-1-xiaodong.liu@intel.com>
On Fri, 10 Feb 2023 09:13:56 -0500, Liu Xiaodong wrote:
> Currently, uring_cmd with UBLK_IO_FETCH_REQ or
> UBLK_IO_COMMIT_AND_FETCH_REQ is always checked whether
> userspace server has provided IO buffer even flag
> UBLK_F_NEED_GET_DATA is configured.
>
> This is a excessive check. If UBLK_F_NEED_GET_DATA is
> configured, FETCH_RQ doesn't need to provide IO buffer;
> COMMIT_AND_FETCH_REQ also doesn't need to do that if
> the IO type is not READ.
>
> [...]
Applied, thanks!
[1/1] block: ublk: check IO buffer based on flag need_get_data
commit: 2f1e07dda1e1310873647abc40bbc49eaf3b10e3
Best regards,
--
Jens Axboe
prev parent reply other threads:[~2023-02-13 15:36 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-02-10 14:13 Liu Xiaodong
2023-02-13 2:37 ` Ming Lei
2023-02-13 15:36 ` Jens Axboe [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=167630261065.98786.1863973416590406572.b4-ty@kernel.dk \
--to=axboe@kernel.dk \
--cc=james.r.harris@intel.com \
--cc=linux-block@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=ming.lei@redhat.com \
--cc=xiaodong.liu@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®