From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 77543C6379F for ; Mon, 13 Feb 2023 16:18:59 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229436AbjBMQS5 (ORCPT ); Mon, 13 Feb 2023 11:18:57 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:36446 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230118AbjBMQSx (ORCPT ); Mon, 13 Feb 2023 11:18:53 -0500 Received: from ams.source.kernel.org (ams.source.kernel.org [145.40.68.75]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 940781BAE6 for ; Mon, 13 Feb 2023 08:18:47 -0800 (PST) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ams.source.kernel.org (Postfix) with ESMTPS id 44662B81601 for ; Mon, 13 Feb 2023 16:18:46 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id A3362C4339B; Mon, 13 Feb 2023 16:18:43 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1676305125; bh=oAM3hbw2sY9KDt+8uK/Y7ws/V1GvEiL5sJUkkO6PiFw=; h=From:To:Cc:In-Reply-To:References:Subject:Date:From; b=NtJ6e0V081StIA7u1c9LrxTBfAbAt4d4KO7FxY2UjzmlIB6f4s8e9Ji4/vmOAjwbs dMCckDMHtXDx7vQaHWN7EaA9TaAVlTFrkiu/ZT9kOC316niGnD88ywjx9vQ9D6ABfo HbdAbNYPymXYrNV9zdjTOXwsc+FyYk9pB3wC7Ibql4j3fAeR3dZpJt1hXW1bQsm9jc 1Zb0rOqCk7xjqpMMUVqaH0EcBNLYNzX1y48ShtOdNcRaCyGvhna897WTdWgzuezU3a EDP6QTmFx0E669FhD0cO74jThxd1d1iTsxRo1J+kaGwGOdVN+rKYaFMbkv+mYCYEhd YsF1vELzwtrOQ== From: Mark Brown To: alsa-devel@alsa-project.org, Alexander Sverdlin Cc: Liam Girdwood , Jaroslav Kysela , Takashi Iwai , linux-kernel@vger.kernel.org In-Reply-To: <20230212220923.258414-1-alexander.sverdlin@gmail.com> References: <20230212220923.258414-1-alexander.sverdlin@gmail.com> Subject: Re: [PATCH] ASoC: ep93xx: ignore 0 Hz sysclk Message-Id: <167630512330.2770751.11991611476848663796.b4-ty@kernel.org> Date: Mon, 13 Feb 2023 16:18:43 +0000 MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit X-Mailer: b4 0.12.0 Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Sun, 12 Feb 2023 23:09:23 +0100, Alexander Sverdlin wrote: > Commit 2458adb8f92a > ("SoC: simple-card-utils: set 0Hz to sysclk when shutdown") > added a call to snd_soc_dai_set_sysclk() with 0 Hz frequency. Being > propagated further it causes a division by zero in clk-ep93xx driver: > > Division by zero in kernel. > CPU: 0 PID: 52 Comm: aplay Tainted: G W 6.2.0-rc4-... #1 > Hardware name: Generic DT based system > unwind_backtrace from show_stack+0x10/0x18 > show_stack from dump_stack_lvl+0x28/0x34 > dump_stack_lvl from __div0+0x10/0x1c > __div0 from Ldiv0+0x8/0x1c > Ldiv0 from ep93xx_mux_determine_rate+0x78/0x1d0 > ep93xx_mux_determine_rate from clk_core_round_rate_nolock+0x48/0xc8 > clk_core_round_rate_nolock from clk_core_set_rate_nolock+0x48/0x160 > clk_core_set_rate_nolock from clk_set_rate+0x30/0x8c > clk_set_rate from ep93xx_i2s_set_sysclk+0x30/0x6c > ep93xx_i2s_set_sysclk from snd_soc_dai_set_sysclk+0x3c/0xa4 > snd_soc_dai_set_sysclk from asoc_simple_shutdown+0xb8/0x164 > asoc_simple_shutdown from snd_soc_link_shutdown+0x44/0x54 > snd_soc_link_shutdown from soc_pcm_clean+0x78/0x180 > soc_pcm_clean from soc_pcm_close+0x28/0x40 > soc_pcm_close from snd_pcm_release_substream.part.0+0x3c/0x84 > snd_pcm_release_substream.part.0 from snd_pcm_release+0x40/0x88 > snd_pcm_release from __fput+0x74/0x278 > > [...] Applied to broonie/sound.git for-next Thanks! [1/1] ASoC: ep93xx: ignore 0 Hz sysclk commit: 66dc3b9b9a6f4b5c7013f15c66073ddd20852b66 All being well this means that it will be integrated into the linux-next tree (usually sometime in the next 24 hours) and sent to Linus during the next merge window (or sooner if it is a bug fix), however if problems are discovered then the patch may be dropped or reverted. You may get further e-mails resulting from automated or manual testing and review of the tree, please engage with people reporting problems and send followup patches addressing any issues that are reported if needed. If any updates are required or you are submitting further changes they should be sent as incremental updates against current git, existing patches will not be replaced. Please add any relevant lists and maintainers to the CCs when replying to this mail. Thanks, Mark