From: Rob Herring <robh@kernel.org>
To: Daniel Golle <daniel@makrotopia.org>
Cc: "Florian Fainelli" <f.fainelli@gmail.com>,
"Eric Dumazet" <edumazet@google.com>,
"Matthias Brugger" <matthias.bgg@gmail.com>,
"AngeloGioacchino Del Regno"
<angelogioacchino.delregno@collabora.com>,
"Jianhui Zhao" <zhaojh329@gmail.com>,
netdev@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
"Krzysztof Kozlowski" <krzysztof.kozlowski+dt@linaro.org>,
"Sean Wang" <sean.wang@mediatek.com>,
"David S. Miller" <davem@davemloft.net>,
"Mark Lee" <Mark-MC.Lee@mediatek.com>,
"Jakub Kicinski" <kuba@kernel.org>, "Bjørn Mork" <bjorn@mork.no>,
"Vladimir Oltean" <olteanv@gmail.com>,
devicetree@vger.kernel.org, linux-mediatek@lists.infradead.org,
"Felix Fietkau" <nbd@nbd.name>,
"Russell King" <linux@armlinux.org.uk>,
"Landen Chao" <Landen.Chao@mediatek.com>,
"Rob Herring" <robh+dt@kernel.org>,
"Heiner Kallweit" <hkallweit1@gmail.com>,
"John Crispin" <john@phrozen.org>,
"Paolo Abeni" <pabeni@redhat.com>,
"DENG Qingfang" <dqfext@gmail.com>,
"Lorenzo Bianconi" <lorenzo@kernel.org>,
"Andrew Lunn" <andrew@lunn.ch>,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH v9 03/12] dt-bindings: arm: mediatek: sgmiisys: Convert to DT schema
Date: Mon, 20 Feb 2023 11:15:53 -0600 [thread overview]
Message-ID: <167691325732.3971281.4378006887073697625.robh@kernel.org> (raw)
In-Reply-To: <03f9d40849dd2d563a93b27732a7b5d7dd1defc5.1676910958.git.daniel@makrotopia.org>
On Mon, 20 Feb 2023 16:41:16 +0000, Daniel Golle wrote:
> Convert mediatek,sgmiiisys bindings to DT schema format.
> Add maintainer Matthias Brugger, no maintainers were listed in the
> original documentation.
> As this node is also referenced by the Ethernet controller and used
> as SGMII PCS add this fact to the description.
> Move the file to Documentation/devicetree/bindings/pcs/ which seems more
> appropriate given that the great majority of registers are related to
> SGMII PCS functionality and only one register represents clock bits.
>
> Reviewed-by: Rob Herring <robh@kernel.org>
> Signed-off-by: Daniel Golle <daniel@makrotopia.org>
> ---
> .../arm/mediatek/mediatek,sgmiisys.txt | 25 ----------
> .../bindings/net/pcs/mediatek,sgmiisys.yaml | 49 +++++++++++++++++++
> 2 files changed, 49 insertions(+), 25 deletions(-)
> delete mode 100644 Documentation/devicetree/bindings/arm/mediatek/mediatek,sgmiisys.txt
> create mode 100644 Documentation/devicetree/bindings/net/pcs/mediatek,sgmiisys.yaml
>
My bot found errors running 'make DT_CHECKER_FLAGS=-m dt_binding_check'
on your patch (DT_CHECKER_FLAGS is new in v5.13):
yamllint warnings/errors:
dtschema/dtc warnings/errors:
./Documentation/devicetree/bindings/net/pcs/mediatek,sgmiisys.yaml: $id: relative path/filename doesn't match actual path or filename
expected: http://devicetree.org/schemas/net/pcs/mediatek,sgmiisys.yaml#
doc reference errors (make refcheckdocs):
See https://patchwork.ozlabs.org/project/devicetree-bindings/patch/03f9d40849dd2d563a93b27732a7b5d7dd1defc5.1676910958.git.daniel@makrotopia.org
The base for the series is generally the latest rc1. A different dependency
should be noted in *this* patch.
If you already ran 'make dt_binding_check' and didn't see the above
error(s), then make sure 'yamllint' is installed and dt-schema is up to
date:
pip3 install dtschema --upgrade
Please check and re-submit after running the above command yourself. Note
that DT_SCHEMA_FILES can be set to your schema file to speed up checking
your schema. However, it must be unset to test all examples with your schema.
next prev parent reply other threads:[~2023-02-20 17:16 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-02-20 16:40 [PATCH v9 00/12] net: ethernet: mtk_eth_soc: various enhancements Daniel Golle
2023-02-20 16:40 ` [PATCH v9 01/12] net: ethernet: mtk_eth_soc: add support for MT7981 SoC Daniel Golle
2023-02-20 16:41 ` [PATCH v9 02/12] dt-bindings: net: mediatek,net: add mt7981-eth binding Daniel Golle
2023-02-20 16:41 ` [PATCH v9 03/12] dt-bindings: arm: mediatek: sgmiisys: Convert to DT schema Daniel Golle
2023-02-20 17:15 ` Rob Herring [this message]
2023-02-20 17:49 ` Daniel Golle
2023-02-20 16:41 ` [PATCH v9 04/12] dt-bindings: arm: mediatek: sgmiisys: add MT7981 SoC Daniel Golle
2023-02-20 16:41 ` [PATCH v9 05/12] net: ethernet: mtk_eth_soc: set MDIO bus clock frequency Daniel Golle
2023-02-20 16:41 ` [PATCH v9 06/12] net: ethernet: mtk_eth_soc: reset PCS state Daniel Golle
2023-02-20 16:41 ` [PATCH v9 07/12] net: ethernet: mtk_eth_soc: only write values if needed Daniel Golle
2023-02-20 16:42 ` [PATCH v9 08/12] net: ethernet: mtk_eth_soc: fix RX data corruption issue Daniel Golle
2023-02-20 16:42 ` [PATCH v9 09/12] net: ethernet: mtk_eth_soc: ppe: add support for flow accounting Daniel Golle
2023-02-20 16:42 ` [PATCH v9 10/12] net: pcs: add driver for MediaTek SGMII PCS Daniel Golle
2023-02-20 16:42 ` [PATCH v9 11/12] net: ethernet: mtk_eth_soc: switch to external PCS driver Daniel Golle
2023-02-20 16:42 ` [PATCH v9 12/12] net: dsa: mt7530: use " Daniel Golle
2023-02-20 19:27 ` [PATCH v9 00/12] net: ethernet: mtk_eth_soc: various enhancements Russell King (Oracle)
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=167691325732.3971281.4378006887073697625.robh@kernel.org \
--to=robh@kernel.org \
--cc=Landen.Chao@mediatek.com \
--cc=Mark-MC.Lee@mediatek.com \
--cc=andrew@lunn.ch \
--cc=angelogioacchino.delregno@collabora.com \
--cc=bjorn@mork.no \
--cc=daniel@makrotopia.org \
--cc=davem@davemloft.net \
--cc=devicetree@vger.kernel.org \
--cc=dqfext@gmail.com \
--cc=edumazet@google.com \
--cc=f.fainelli@gmail.com \
--cc=hkallweit1@gmail.com \
--cc=john@phrozen.org \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=kuba@kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mediatek@lists.infradead.org \
--cc=linux@armlinux.org.uk \
--cc=lorenzo@kernel.org \
--cc=matthias.bgg@gmail.com \
--cc=nbd@nbd.name \
--cc=netdev@vger.kernel.org \
--cc=olteanv@gmail.com \
--cc=pabeni@redhat.com \
--cc=robh+dt@kernel.org \
--cc=sean.wang@mediatek.com \
--cc=zhaojh329@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®