From: Rob Herring <robh@kernel.org>
To: Linus Walleij <linus.walleij@linaro.org>
Cc: Lee Jones <lee@kernel.org>,
devicetree@vger.kernel.org, Stefan Agner <stefan@agner.ch>,
Rob Herring <robh+dt@kernel.org>, Marek Vasut <marex@denx.de>,
linux-kernel@vger.kernel.org,
Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
Philippe Schenker <philippe.schenker@toradex.com>
Subject: Re: [PATCH] dt-bindings: MFD: Convert STMPE to YAML schema
Date: Tue, 21 Feb 2023 07:57:52 -0600 [thread overview]
Message-ID: <167698731618.2349693.5906822374742470475.robh@kernel.org> (raw)
In-Reply-To: <20230221102605.2007396-1-linus.walleij@linaro.org>
On Tue, 21 Feb 2023 11:26:05 +0100, Linus Walleij wrote:
> This converts the STMPE MFD device tree bindings to the YAML
> schema.
>
> Reference the existing schema for the ADC, just define the
> other subnode schemas directly in the MFD schema.
>
> Add two examples so we have examples covering both the simple
> GPIO expander and the more complex with ADC and touchscreen.
>
> Some in-tree users do not follow the naming conventions for nodes
> so these DTS files need to be augmented to use proper node names
> like "adc", "pwm", "gpio", "keyboard-controller" etc before the
> bindings take effect on them.
>
> Cc: Rob Herring <robh+dt@kernel.org>
> Cc: Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>
> Cc: devicetree@vger.kernel.org
> Cc: Stefan Agner <stefan@agner.ch>
> Cc: Marek Vasut <marex@denx.de>
> Cc: Philippe Schenker <philippe.schenker@toradex.com>
> Signed-off-by: Linus Walleij <linus.walleij@linaro.org>
> ---
> I chose to keep the IIO ADC separate YAML file, and contain the
> rest in the MFD YAML file.
>
> I can pull the IIO ADC it into the MFD YAML file, I can push out
> sub-YAML files per compatible, happy to do it any way you folks
> like, just tell me what to do.
> ---
> .../bindings/input/stmpe-keypad.txt | 41 ---
> .../bindings/input/touchscreen/stmpe.txt | 108 ------
> .../devicetree/bindings/mfd/st,stmpe.yaml | 344 ++++++++++++++++++
> .../devicetree/bindings/mfd/stmpe.txt | 42 ---
> 4 files changed, 344 insertions(+), 191 deletions(-)
> delete mode 100644 Documentation/devicetree/bindings/input/stmpe-keypad.txt
> delete mode 100644 Documentation/devicetree/bindings/input/touchscreen/stmpe.txt
> create mode 100644 Documentation/devicetree/bindings/mfd/st,stmpe.yaml
> delete mode 100644 Documentation/devicetree/bindings/mfd/stmpe.txt
>
Running 'make dtbs_check' with the schema in this patch gives the
following warnings. Consider if they are expected or the schema is
incorrect. These may not be new warnings.
Note that it is not yet a requirement to have 0 warnings for dtbs_check.
This will change in the future.
Full log is available here: https://patchwork.ozlabs.org/project/devicetree-bindings/patch/20230221102605.2007396-1-linus.walleij@linaro.org
adc@41: $nodename:0: 'adc@41' does not match '^stmpe[0-9]+@[0-9a-f]+$'
arch/arm/boot/dts/exynos4412-p4note-n8010.dtb
adc@41: 'interrupt-controller', 'irq-trigger', 'stmpe_adc' do not match any of the regexes: 'pinctrl-[0-9]+'
arch/arm/boot/dts/exynos4412-p4note-n8010.dtb
gpio-expander@44: $nodename:0: 'gpio-expander@44' does not match '^stmpe[0-9]+@[0-9a-f]+$'
arch/arm/boot/dts/imx6ul-isiot-emmc.dtb
arch/arm/boot/dts/imx6ul-isiot-nand.dtb
gpio-expander@44: '#interrupt-cells', 'interrupt-controller' do not match any of the regexes: 'pinctrl-[0-9]+'
arch/arm/boot/dts/imx6ul-isiot-emmc.dtb
arch/arm/boot/dts/imx6ul-isiot-nand.dtb
gpio-expander@44: touchscreen: Unevaluated properties are not allowed ('st,adc-freq', 'st,mod-12b', 'st,ref-sel', 'st,sample-time' were unexpected)
arch/arm/boot/dts/imx6ul-isiot-emmc.dtb
arch/arm/boot/dts/imx6ul-isiot-nand.dtb
stmpe1600@42: 'interrupt-controller', 'stmpe_gpio' do not match any of the regexes: 'pinctrl-[0-9]+'
arch/arm/boot/dts/stm32429i-eval.dtb
stmpe1601@40: 'interrupt-controller', 'stmpe_keypad' do not match any of the regexes: 'pinctrl-[0-9]+'
arch/arm/boot/dts/ste-hrefprev60-stuib.dtb
arch/arm/boot/dts/ste-hrefv60plus-stuib.dtb
stmpe1601@40: 'stmpe_gpio' does not match any of the regexes: 'pinctrl-[0-9]+'
arch/arm/boot/dts/imx6q-dmo-edmqmx6.dtb
stmpe1601@44: 'stmpe_gpio' does not match any of the regexes: 'pinctrl-[0-9]+'
arch/arm/boot/dts/imx6q-dmo-edmqmx6.dtb
stmpe2401@43: 'interrupt-controller', 'stmpe_gpio', 'stmpe_keypad', 'stmpe_pwm' do not match any of the regexes: 'pinctrl-[0-9]+'
arch/arm/boot/dts/ste-nomadik-nhk15.dtb
stmpe2401@44: 'interrupt-controller', 'stmpe_gpio' do not match any of the regexes: 'pinctrl-[0-9]+'
arch/arm/boot/dts/ste-nomadik-nhk15.dtb
stmpe@41: $nodename:0: 'stmpe@41' does not match '^stmpe[0-9]+@[0-9a-f]+$'
arch/arm/boot/dts/imx6dl-phytec-pbab01.dtb
arch/arm/boot/dts/imx6q-phytec-pbab01.dtb
stmpe@41: 'oneOf' conditional failed, one must be fixed:
arch/arm/boot/dts/imx6dl-phytec-pbab01.dtb
arch/arm/boot/dts/imx6q-phytec-pbab01.dtb
stmpe801@41: '#address-cells', '#size-cells', 'irq-trigger', 'stmpe_gpio' do not match any of the regexes: 'pinctrl-[0-9]+'
arch/arm/boot/dts/spear1340-evb.dtb
stmpe811@41: '#address-cells', '#size-cells', 'blocks', 'id', 'irq-gpios', 'irq-trigger', 'stmpe-gpio', 'stmpe610-ts' do not match any of the regexes: 'pinctrl-[0-9]+'
arch/arm/boot/dts/spear320-hmi.dtb
stmpe811@41: '#address-cells', '#size-cells', 'blocks', 'id', 'irq-gpio', 'stmpe_touchscreen' do not match any of the regexes: 'pinctrl-[0-9]+'
arch/arm/boot/dts/socfpga_cyclone5_mcvevk.dtb
stmpe811@41: 'blocks', 'id', 'interrupt-controller', 'irq-trigger', 'stmpe_adc', 'stmpe_gpio', 'stmpe_pwm', 'stmpe_touchscreen' do not match any of the regexes: 'pinctrl-[0-9]+'
arch/arm/boot/dts/am5729-beagleboneai.dtb
stmpe811@41: 'blocks', 'id', 'interrupt-controller', 'irq-trigger', 'stmpe_adc', 'stmpe_touchscreen' do not match any of the regexes: 'pinctrl-[0-9]+'
arch/arm/boot/dts/imx6dl-colibri-aster.dtb
arch/arm/boot/dts/imx6dl-colibri-eval-v3.dtb
arch/arm/boot/dts/imx6dl-colibri-iris.dtb
arch/arm/boot/dts/imx6dl-colibri-iris-v2.dtb
arch/arm/boot/dts/imx6q-apalis-eval.dtb
arch/arm/boot/dts/imx6q-apalis-ixora.dtb
arch/arm/boot/dts/imx6q-apalis-ixora-v1.1.dtb
arch/arm/boot/dts/imx6q-apalis-ixora-v1.2.dtb
stmpe811@41: 'oneOf' conditional failed, one must be fixed:
arch/arm/boot/dts/socfpga_cyclone5_mcvevk.dtb
arch/arm/boot/dts/spear320-hmi.dtb
stmpe811@41: 'stmpe_adc', 'stmpe_touchscreen' do not match any of the regexes: 'pinctrl-[0-9]+'
arch/arm/boot/dts/stm32f429-disco.dtb
stmpe811@44: 'blocks', 'id', 'irq-gpio', 'irq-trigger', 'stmpe_touchscreen' do not match any of the regexes: 'pinctrl-[0-9]+'
arch/arm/boot/dts/imx6q-novena.dtb
stmpe811@44: 'oneOf' conditional failed, one must be fixed:
arch/arm/boot/dts/imx6q-novena.dtb
stmpe811@44: 'stmpe_touchscreen' does not match any of the regexes: 'pinctrl-[0-9]+'
arch/arm/boot/dts/r8a7745-iwg22d-sodimm-dbhd-ca.dtb
arch/arm/boot/dts/r8a7745-iwg22d-sodimm.dtb
touchctrl@44: $nodename:0: 'touchctrl@44' does not match '^stmpe[0-9]+@[0-9a-f]+$'
arch/arm/boot/dts/imx6dl-phytec-mira-rdk-nand.dtb
arch/arm/boot/dts/imx6q-phytec-mira-rdk-emmc.dtb
arch/arm/boot/dts/imx6q-phytec-mira-rdk-nand.dtb
arch/arm/boot/dts/imx6qp-phytec-mira-rdk-nand.dtb
touchctrl@44: 'stmpe_touchscreen' does not match any of the regexes: 'pinctrl-[0-9]+'
arch/arm/boot/dts/imx6dl-phytec-mira-rdk-nand.dtb
arch/arm/boot/dts/imx6q-phytec-mira-rdk-emmc.dtb
arch/arm/boot/dts/imx6q-phytec-mira-rdk-nand.dtb
arch/arm/boot/dts/imx6qp-phytec-mira-rdk-nand.dtb
touchscreen@41: $nodename:0: 'touchscreen@41' does not match '^stmpe[0-9]+@[0-9a-f]+$'
arch/arm/boot/dts/imx6ull-tqma6ull2l-mba6ulx.dtb
arch/arm/boot/dts/imx6ull-tqma6ull2-mba6ulx.dtb
arch/arm/boot/dts/imx6ul-tqma6ul1-mba6ulx.dtb
arch/arm/boot/dts/imx6ul-tqma6ul2l-mba6ulx.dtb
arch/arm/boot/dts/imx6ul-tqma6ul2-mba6ulx.dtb
arch/arm/boot/dts/tegra30-apalis-eval.dtb
arch/arm/boot/dts/tegra30-apalis-v1.1-eval.dtb
arch/arm/boot/dts/tegra30-colibri-eval-v3.dtb
touchscreen@41: 'blocks', 'id', 'interrupt-controller', 'irq-gpio', 'irq-trigger', 'stmpe_adc', 'stmpe_touchscreen' do not match any of the regexes: 'pinctrl-[0-9]+'
arch/arm/boot/dts/tegra30-apalis-eval.dtb
arch/arm/boot/dts/tegra30-apalis-v1.1-eval.dtb
arch/arm/boot/dts/tegra30-colibri-eval-v3.dtb
touchscreen@41: 'interrupt-controller', 'stmpe_touchscreen' do not match any of the regexes: 'pinctrl-[0-9]+'
arch/arm/boot/dts/imx6ull-tqma6ull2l-mba6ulx.dtb
arch/arm/boot/dts/imx6ull-tqma6ull2-mba6ulx.dtb
arch/arm/boot/dts/imx6ul-tqma6ul1-mba6ulx.dtb
arch/arm/boot/dts/imx6ul-tqma6ul2l-mba6ulx.dtb
arch/arm/boot/dts/imx6ul-tqma6ul2-mba6ulx.dtb
touchscreen@41: 'oneOf' conditional failed, one must be fixed:
arch/arm/boot/dts/tegra30-apalis-eval.dtb
arch/arm/boot/dts/tegra30-apalis-v1.1-eval.dtb
arch/arm/boot/dts/tegra30-colibri-eval-v3.dtb
touchscreen@44: $nodename:0: 'touchscreen@44' does not match '^stmpe[0-9]+@[0-9a-f]+$'
arch/arm/boot/dts/imx6ull-phytec-segin-ff-rdk-emmc.dtb
arch/arm/boot/dts/imx6ull-phytec-segin-ff-rdk-nand.dtb
arch/arm/boot/dts/imx6ul-phytec-segin-ff-rdk-emmc.dtb
arch/arm/boot/dts/imx6ul-phytec-segin-ff-rdk-nand.dtb
arch/arm/boot/dts/rk3288-phycore-rdk.dtb
touchscreen@44: 'oneOf' conditional failed, one must be fixed:
arch/arm/boot/dts/rk3288-phycore-rdk.dtb
touchscreen@44: 'stmpe_touchscreen' does not match any of the regexes: 'pinctrl-[0-9]+'
arch/arm/boot/dts/imx6ull-phytec-segin-ff-rdk-emmc.dtb
arch/arm/boot/dts/imx6ull-phytec-segin-ff-rdk-nand.dtb
arch/arm/boot/dts/imx6ul-phytec-segin-ff-rdk-emmc.dtb
arch/arm/boot/dts/imx6ul-phytec-segin-ff-rdk-nand.dtb
next prev parent reply other threads:[~2023-02-21 13:58 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-02-21 10:26 Linus Walleij
2023-02-21 13:57 ` Rob Herring [this message]
2023-02-21 20:23 ` Linus Walleij
2023-02-24 10:14 ` Krzysztof Kozlowski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=167698731618.2349693.5906822374742470475.robh@kernel.org \
--to=robh@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=lee@kernel.org \
--cc=linus.walleij@linaro.org \
--cc=linux-kernel@vger.kernel.org \
--cc=marex@denx.de \
--cc=philippe.schenker@toradex.com \
--cc=robh+dt@kernel.org \
--cc=stefan@agner.ch \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®