From: Jens Axboe <axboe@kernel.dk>
To: code@siddh.me, willy@infradead.org,
Zhong Jinghua <zhongjinghua@huaweicloud.com>
Cc: linux-block@vger.kernel.org, linux-kernel@vger.kernel.org,
zhongjinghua@huawei.com, yi.zhang@huawei.com, yukuai3@huawei.com,
houtao1@huawei.com
Subject: Re: [PATCH-next v4] loop: loop_set_status_from_info() check before assignment
Date: Wed, 22 Feb 2023 20:43:28 -0700 [thread overview]
Message-ID: <167712380884.13855.10551951254719805732.b4-ty@kernel.dk> (raw)
In-Reply-To: <20230221095027.3656193-1-zhongjinghua@huaweicloud.com>
On Tue, 21 Feb 2023 17:50:27 +0800, Zhong Jinghua wrote:
> In loop_set_status_from_info(), lo->lo_offset and lo->lo_sizelimit should
> be checked before reassignment, because if an overflow error occurs, the
> original correct value will be changed to the wrong value, and it will not
> be changed back.
>
> More, the original patch did not solve the problem, the value was set and
> ioctl returned an error, but the subsequent io used the value in the loop
> driver, which still caused an alarm:
>
> [...]
Applied, thanks!
[1/1] loop: loop_set_status_from_info() check before assignment
commit: 9f6ad5d533d1c71e51bdd06a5712c4fbc8768dfa
Best regards,
--
Jens Axboe
prev parent reply other threads:[~2023-02-23 3:43 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-02-21 9:50 Zhong Jinghua
2023-02-21 17:59 ` Chaitanya Kulkarni
2023-02-23 3:43 ` Jens Axboe [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=167712380884.13855.10551951254719805732.b4-ty@kernel.dk \
--to=axboe@kernel.dk \
--cc=code@siddh.me \
--cc=houtao1@huawei.com \
--cc=linux-block@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=willy@infradead.org \
--cc=yi.zhang@huawei.com \
--cc=yukuai3@huawei.com \
--cc=zhongjinghua@huawei.com \
--cc=zhongjinghua@huaweicloud.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®