mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Prashanth K <quic_prashk@quicinc.com>
To: "Greg Kroah-Hartman" <gregkh@linuxfoundation.org>,
	"Thinh Nguyen" <Thinh.Nguyen@synopsys.com>,
	"Jakob Koschel" <jakobkoschel@gmail.com>,
	"Jó Ágila Bitsch" <jgilab@gmail.com>,
	"Alan Stern" <stern@rowland.harvard.edu>
Cc: Pratham Pratap <quic_ppratap@quicinc.com>,
	Jack Pham <quic_jackp@quicinc.com>, <linux-usb@vger.kernel.org>,
	<linux-kernel@vger.kernel.org>,
	Prashanth K <quic_prashk@quicinc.com>
Subject: [PATCH v3 2/2] usb: gadget: composite: Draw 100mA current if not configured
Date: Thu, 23 Feb 2023 18:12:01 +0530	[thread overview]
Message-ID: <1677156121-30364-3-git-send-email-quic_prashk@quicinc.com> (raw)
In-Reply-To: <1677156121-30364-1-git-send-email-quic_prashk@quicinc.com>

Currently we don't change the current value if device isn't in
configured state. But the battery charging specification says,
device can draw up to 100mA of current if its in unconfigured
state. Hence add a Vbus_draw work in composite_resume to draw
100mA if the device isn't configured.

Signed-off-by: Prashanth K <quic_prashk@quicinc.com>
---
 drivers/usb/gadget/composite.c | 4 ++++
 1 file changed, 4 insertions(+)

diff --git a/drivers/usb/gadget/composite.c b/drivers/usb/gadget/composite.c
index 403563c..386140f 100644
--- a/drivers/usb/gadget/composite.c
+++ b/drivers/usb/gadget/composite.c
@@ -2449,6 +2449,10 @@ void composite_resume(struct usb_gadget *gadget)
 			usb_gadget_clear_selfpowered(gadget);
 
 		usb_gadget_vbus_draw(gadget, maxpower);
+	} else {
+		maxpower = CONFIG_USB_GADGET_VBUS_DRAW;
+		maxpower = min(maxpower, 100U);
+		usb_gadget_vbus_draw(gadget, maxpower);
 	}
 
 	cdev->suspended = 0;
-- 
2.7.4


  parent reply	other threads:[~2023-02-23 12:42 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-02-23 12:41 [PATCH v3 0/2] Fix vbus draw of dwc3 gadget Prashanth K
2023-02-23 12:42 ` [PATCH v3 1/2] usb: dwc3: gadget: Change condition for processing suspend event Prashanth K
2023-02-23 20:03   ` Thinh Nguyen
2023-02-23 12:42 ` Prashanth K [this message]
2023-02-23 20:10   ` [PATCH v3 2/2] usb: gadget: composite: Draw 100mA current if not configured Thinh Nguyen
2023-02-24  4:57     ` Prashanth K
2023-02-24 18:38       ` Thinh Nguyen
2023-02-25  6:35         ` Prashanth K
2023-02-27 19:38           ` Thinh Nguyen

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1677156121-30364-3-git-send-email-quic_prashk@quicinc.com \
    --to=quic_prashk@quicinc.com \
    --cc=Thinh.Nguyen@synopsys.com \
    --cc=gregkh@linuxfoundation.org \
    --cc=jakobkoschel@gmail.com \
    --cc=jgilab@gmail.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-usb@vger.kernel.org \
    --cc=quic_jackp@quicinc.com \
    --cc=quic_ppratap@quicinc.com \
    --cc=stern@rowland.harvard.edu \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®