From: "tip-bot2 for Josh Poimboeuf" <tip-bot2@linutronix.de>
To: linux-tip-commits@vger.kernel.org
Cc: Josh Poimboeuf <jpoimboe@kernel.org>,
x86@kernel.org, linux-kernel@vger.kernel.org
Subject: [tip: objtool/core] xtensa/cpu: Make sure cpu_die() doesn't return
Date: Fri, 10 Mar 2023 20:54:48 -0000 [thread overview]
Message-ID: <167848168863.5837.637085090455640645.tip-bot2@tip-bot2> (raw)
In-Reply-To: <cca346b5c87693499e630291d78fb0bf12c24290.1676358308.git.jpoimboe@kernel.org>
The following commit has been merged into the objtool/core branch of tip:
Commit-ID: d08e12e8126ec88d6cb1a7eb160d8d7b52c8699f
Gitweb: https://git.kernel.org/tip/d08e12e8126ec88d6cb1a7eb160d8d7b52c8699f
Author: Josh Poimboeuf <jpoimboe@kernel.org>
AuthorDate: Mon, 13 Feb 2023 23:05:53 -08:00
Committer: Josh Poimboeuf <jpoimboe@kernel.org>
CommitterDate: Wed, 08 Mar 2023 08:44:27 -08:00
xtensa/cpu: Make sure cpu_die() doesn't return
cpu_die() doesn't return. Make that more explicit with a BUG().
BUG() is preferable to unreachable() because BUG() is a more explicit
failure mode and avoids undefined behavior like falling off the edge of
the function into whatever code happens to be next.
Link: https://lore.kernel.org/r/cca346b5c87693499e630291d78fb0bf12c24290.1676358308.git.jpoimboe@kernel.org
Signed-off-by: Josh Poimboeuf <jpoimboe@kernel.org>
---
arch/xtensa/kernel/smp.c | 2 ++
1 file changed, 2 insertions(+)
diff --git a/arch/xtensa/kernel/smp.c b/arch/xtensa/kernel/smp.c
index 4dc109d..7bad784 100644
--- a/arch/xtensa/kernel/smp.c
+++ b/arch/xtensa/kernel/smp.c
@@ -341,6 +341,8 @@ void __ref cpu_die(void)
__asm__ __volatile__(
" movi a2, cpu_restart\n"
" jx a2\n");
+
+ BUG();
}
#endif /* CONFIG_HOTPLUG_CPU */
next prev parent reply other threads:[~2023-03-10 20:55 UTC|newest]
Thread overview: 82+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-02-14 7:05 [PATCH v2 00/24] cpu,sched: Mark arch_cpu_idle_dead() __noreturn Josh Poimboeuf
2023-02-14 7:05 ` [PATCH v2 01/24] alpha/cpu: Expose arch_cpu_idle_dead()'s prototype declaration Josh Poimboeuf
2023-03-10 20:54 ` [tip: objtool/core] " tip-bot2 for Josh Poimboeuf
2023-02-14 7:05 ` [PATCH v2 02/24] alpha/cpu: Make sure arch_cpu_idle_dead() doesn't return Josh Poimboeuf
2023-03-10 20:54 ` [tip: objtool/core] " tip-bot2 for Josh Poimboeuf
2023-02-14 7:05 ` [PATCH v2 03/24] arm/cpu: " Josh Poimboeuf
2023-02-14 11:15 ` Russell King (Oracle)
2023-02-14 18:39 ` Josh Poimboeuf
2023-02-14 22:01 ` Russell King (Oracle)
2023-02-16 18:38 ` [PATCH v2.1 03/24] arm/cpu: Add unreachable() to arch_cpu_idle_dead() Josh Poimboeuf
2023-03-10 20:54 ` [tip: objtool/core] " tip-bot2 for Josh Poimboeuf
2023-02-14 7:05 ` [PATCH v2 04/24] arm64/cpu: Mark cpu_die() __noreturn Josh Poimboeuf
2023-02-14 8:13 ` Philippe Mathieu-Daudé
2023-02-15 13:09 ` Mark Rutland
2023-02-15 19:45 ` Josh Poimboeuf
2023-02-16 18:41 ` [PATCH v2.1 " Josh Poimboeuf
2023-03-02 10:55 ` Philippe Mathieu-Daudé
2023-03-10 20:54 ` [tip: objtool/core] " tip-bot2 for Josh Poimboeuf
2023-02-14 7:05 ` [PATCH v2 05/24] csky/cpu: Make sure arch_cpu_idle_dead() doesn't return Josh Poimboeuf
2023-03-10 20:54 ` [tip: objtool/core] " tip-bot2 for Josh Poimboeuf
2023-02-14 7:05 ` [PATCH v2 06/24] ia64/cpu: Mark play_dead() __noreturn Josh Poimboeuf
2023-02-14 8:07 ` Philippe Mathieu-Daudé
2023-03-10 20:54 ` [tip: objtool/core] " tip-bot2 for Josh Poimboeuf
2023-02-14 7:05 ` [PATCH v2 07/24] loongarch/cpu: Make sure play_dead() doesn't return Josh Poimboeuf
2023-03-10 20:54 ` [tip: objtool/core] " tip-bot2 for Josh Poimboeuf
2023-02-14 7:05 ` [PATCH v2 08/24] loongarch/cpu: Mark play_dead() __noreturn Josh Poimboeuf
2023-02-14 8:06 ` Philippe Mathieu-Daudé
2023-03-10 20:54 ` [tip: objtool/core] " tip-bot2 for Josh Poimboeuf
2023-02-14 7:05 ` [PATCH v2 09/24] mips/cpu: Expose play_dead()'s prototype definition Josh Poimboeuf
2023-02-14 7:46 ` Philippe Mathieu-Daudé
2023-02-14 18:11 ` Josh Poimboeuf
2023-02-15 8:29 ` Philippe Mathieu-Daudé
2023-02-16 18:42 ` [PATCH v2.1 " Josh Poimboeuf
2023-03-01 18:16 ` Josh Poimboeuf
2023-03-02 10:54 ` Philippe Mathieu-Daudé
2023-03-10 20:54 ` [tip: objtool/core] " tip-bot2 for Josh Poimboeuf
2023-02-14 7:05 ` [PATCH v2 10/24] mips/cpu: Make sure play_dead() doesn't return Josh Poimboeuf
2023-02-14 7:50 ` Philippe Mathieu-Daudé
2023-03-10 20:54 ` [tip: objtool/core] " tip-bot2 for Josh Poimboeuf
2023-02-14 7:05 ` [PATCH v2 11/24] mips/cpu: Mark play_dead() __noreturn Josh Poimboeuf
2023-02-14 7:50 ` Philippe Mathieu-Daudé
2023-03-10 20:54 ` [tip: objtool/core] " tip-bot2 for Josh Poimboeuf
2023-02-14 7:05 ` [PATCH v2 12/24] powerpc/cpu: Mark start_secondary_resume() __noreturn Josh Poimboeuf
2023-02-14 7:19 ` Christophe Leroy
2023-03-10 20:54 ` [tip: objtool/core] " tip-bot2 for Josh Poimboeuf
2023-02-14 7:05 ` [PATCH v2 13/24] sh/cpu: Make sure play_dead() doesn't return Josh Poimboeuf
2023-02-14 7:57 ` Philippe Mathieu-Daudé
2023-02-14 18:28 ` Josh Poimboeuf
2023-03-10 20:54 ` [tip: objtool/core] " tip-bot2 for Josh Poimboeuf
2023-02-14 7:05 ` [PATCH v2 14/24] sh/cpu: Mark play_dead() __noreturn Josh Poimboeuf
2023-03-10 20:54 ` [tip: objtool/core] " tip-bot2 for Josh Poimboeuf
2023-02-14 7:05 ` [PATCH v2 15/24] sh/cpu: Expose arch_cpu_idle_dead()'s prototype definition Josh Poimboeuf
2023-03-10 20:54 ` [tip: objtool/core] " tip-bot2 for Josh Poimboeuf
2023-02-14 7:05 ` [PATCH v2 16/24] sparc/cpu: Mark cpu_play_dead() __noreturn Josh Poimboeuf
2023-02-14 7:52 ` Philippe Mathieu-Daudé
2023-03-10 20:54 ` [tip: objtool/core] " tip-bot2 for Josh Poimboeuf
2023-02-14 7:05 ` [PATCH v2 17/24] x86/cpu: Make sure play_dead() doesn't return Josh Poimboeuf
2023-02-14 8:05 ` Philippe Mathieu-Daudé
2023-03-10 20:54 ` [tip: objtool/core] " tip-bot2 for Josh Poimboeuf
2023-02-14 7:05 ` [PATCH v2 18/24] x86/cpu: Mark play_dead() __noreturn Josh Poimboeuf
2023-03-10 20:54 ` [tip: objtool/core] " tip-bot2 for Josh Poimboeuf
2023-02-14 7:05 ` [PATCH v2 19/24] xtensa/cpu: Make sure cpu_die() doesn't return Josh Poimboeuf
2023-02-14 7:55 ` Philippe Mathieu-Daudé
2023-02-14 18:23 ` Josh Poimboeuf
2023-02-14 19:29 ` Steven Rostedt
2023-02-14 19:48 ` Max Filippov
2023-02-14 20:19 ` Josh Poimboeuf
2023-03-10 20:54 ` tip-bot2 for Josh Poimboeuf [this message]
2023-02-14 7:05 ` [PATCH v2 20/24] xtensa/cpu: Mark cpu_die() __noreturn Josh Poimboeuf
2023-02-14 12:47 ` Max Filippov
2023-03-10 20:54 ` [tip: objtool/core] " tip-bot2 for Josh Poimboeuf
2023-02-14 7:05 ` [PATCH v2 21/24] sched/idle: Make sure weak version of arch_cpu_idle_dead() doesn't return Josh Poimboeuf
2023-03-10 20:54 ` [tip: objtool/core] " tip-bot2 for Josh Poimboeuf
2023-02-14 7:05 ` [PATCH v2 22/24] objtool: Include weak functions in 'global_noreturns' check Josh Poimboeuf
2023-02-14 7:05 ` [PATCH v2 23/24] init: Make arch_call_rest_init() and rest_init() __noreturn Josh Poimboeuf
2023-02-14 7:05 ` [PATCH v2 24/24] sched/idle: Mark arch_cpu_idle_dead() __noreturn Josh Poimboeuf
2023-03-10 20:54 ` [tip: objtool/core] " tip-bot2 for Josh Poimboeuf
2023-02-14 8:38 ` [PATCH v2 25/24] x86/cpu: Expose arch_cpu_idle_dead()'s prototype definition Philippe Mathieu-Daudé
2023-03-10 20:54 ` [tip: objtool/core] " tip-bot2 for Philippe Mathieu-Daudé
2023-02-14 9:25 ` [PATCH v2 00/24] cpu,sched: Mark arch_cpu_idle_dead() __noreturn Philippe Mathieu-Daudé
2023-02-14 18:29 ` Josh Poimboeuf
2023-02-15 22:22 ` Paul E. McKenney
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=167848168863.5837.637085090455640645.tip-bot2@tip-bot2 \
--to=tip-bot2@linutronix.de \
--cc=jpoimboe@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-tip-commits@vger.kernel.org \
--cc=x86@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®