From: Jens Axboe <axboe@kernel.dk>
To: agk@redhat.com, snitzer@kernel.org, dm-devel@redhat.com,
kbusch@kernel.org, hch@lst.de, sagi@grimberg.me,
guz.fnst@cn.fujitsu.com, Yu Kuai <yukuai1@huaweicloud.com>
Cc: linux-block@vger.kernel.org, linux-kernel@vger.kernel.org,
linux-nvme@lists.infradead.org, yukuai3@huawei.com,
yi.zhang@huawei.com, yangerkun@huawei.com
Subject: Re: [PATCH -next RFC] block: count 'ios' and 'sectors' when io is done for bio-based device
Date: Wed, 15 Mar 2023 09:25:39 -0600 [thread overview]
Message-ID: <167889393912.42717.4228399799157411797.b4-ty@kernel.dk> (raw)
In-Reply-To: <20230223091226.1135678-1-yukuai1@huaweicloud.com>
On Thu, 23 Feb 2023 17:12:26 +0800, Yu Kuai wrote:
> While using iostat for raid, I observed very strange 'await'
> occasionally, and turns out it's due to that 'ios' and 'sectors' is
> counted in bdev_start_io_acct(), while 'nsecs' is counted in
> bdev_end_io_acct(). I'm not sure why they are ccounted like that
> but I think this behaviour is obviously wrong because user will get
> wrong disk stats.
>
> [...]
Applied, thanks!
[1/1] block: count 'ios' and 'sectors' when io is done for bio-based device
commit: 5f27571382ca42daa3e3d40d1b252bf18c2b61d2
Best regards,
--
Jens Axboe
prev parent reply other threads:[~2023-03-15 15:25 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-02-23 9:12 Yu Kuai
2023-02-28 1:01 ` Yu Kuai
2023-03-07 10:44 ` Yu Kuai
2023-03-15 15:10 ` Christoph Hellwig
2023-03-15 15:25 ` Jens Axboe [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=167889393912.42717.4228399799157411797.b4-ty@kernel.dk \
--to=axboe@kernel.dk \
--cc=agk@redhat.com \
--cc=dm-devel@redhat.com \
--cc=guz.fnst@cn.fujitsu.com \
--cc=hch@lst.de \
--cc=kbusch@kernel.org \
--cc=linux-block@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-nvme@lists.infradead.org \
--cc=sagi@grimberg.me \
--cc=snitzer@kernel.org \
--cc=yangerkun@huawei.com \
--cc=yi.zhang@huawei.com \
--cc=yukuai1@huaweicloud.com \
--cc=yukuai3@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®