mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: patchwork-bot+netdevbpf@kernel.org
To: Viktor Malik <vmalik@redhat.com>
Cc: bpf@vger.kernel.org, mcgrof@kernel.org, ast@kernel.org,
	daniel@iogearbox.net, john.fastabend@gmail.com,
	andrii@kernel.org, martin.lau@linux.dev, song@kernel.org,
	yhs@fb.com, kpsingh@kernel.org, sdf@google.com,
	haoluo@google.com, jolsa@kernel.org,
	linux-modules@vger.kernel.org, linux-kernel@vger.kernel.org,
	lkp@intel.com
Subject: Re: [PATCH bpf-next] kallsyms: move find_kallsyms_symbol_value out of internal header
Date: Fri, 17 Mar 2023 12:50:18 +0000	[thread overview]
Message-ID: <167905741806.12724.17197641552332492380.git-patchwork-notify@kernel.org> (raw)
In-Reply-To: <20230317095601.386738-1-vmalik@redhat.com>

Hello:

This patch was applied to bpf/bpf-next.git (master)
by Daniel Borkmann <daniel@iogearbox.net>:

On Fri, 17 Mar 2023 10:56:01 +0100 you wrote:
> Moving find_kallsyms_symbol_value from kernel/module/internal.h to
> include/linux/module.h. The reason is that internal.h is not prepared to
> be included when CONFIG_MODULES=n. find_kallsyms_symbol_value is used by
> kernel/bpf/verifier.c and including internal.h from it (without modules)
> leads into a compilation error:
> 
> In file included from ../include/linux/container_of.h:5,
>                  from ../include/linux/list.h:5,
>                  from ../include/linux/timer.h:5,
>                  from ../include/linux/workqueue.h:9,
>                  from ../include/linux/bpf.h:10,
>                  from ../include/linux/bpf-cgroup.h:5,
>                  from ../kernel/bpf/verifier.c:7:
> ../kernel/bpf/../module/internal.h: In function 'mod_find':
> ../include/linux/container_of.h:20:54: error: invalid use of undefined type 'struct module'
>    20 |         static_assert(__same_type(*(ptr), ((type *)0)->member) ||       \
>       |                                                      ^~
> [...]
> 
> [...]

Here is the summary with links:
  - [bpf-next] kallsyms: move find_kallsyms_symbol_value out of internal header
    https://git.kernel.org/bpf/bpf-next/c/bd5314f8dd2d

You are awesome, thank you!
-- 
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html



      reply	other threads:[~2023-03-17 12:50 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-03-17  9:56 Viktor Malik
2023-03-17 12:50 ` patchwork-bot+netdevbpf [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=167905741806.12724.17197641552332492380.git-patchwork-notify@kernel.org \
    --to=patchwork-bot+netdevbpf@kernel.org \
    --cc=andrii@kernel.org \
    --cc=ast@kernel.org \
    --cc=bpf@vger.kernel.org \
    --cc=daniel@iogearbox.net \
    --cc=haoluo@google.com \
    --cc=john.fastabend@gmail.com \
    --cc=jolsa@kernel.org \
    --cc=kpsingh@kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-modules@vger.kernel.org \
    --cc=lkp@intel.com \
    --cc=martin.lau@linux.dev \
    --cc=mcgrof@kernel.org \
    --cc=sdf@google.com \
    --cc=song@kernel.org \
    --cc=vmalik@redhat.com \
    --cc=yhs@fb.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®