From: Mikael Pettersson <mikpe@csd.uu.se>
To: Rusty Russell <rusty@rustcorp.com.au>
Cc: Andrew Morton <akpm@osdl.org>,
lkml - Kernel Mailing List <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH][2.6.10-rc1-mm4][3/4] perfctr x86 driver updates
Date: Mon, 15 Nov 2004 10:18:36 +0100 [thread overview]
Message-ID: <16792.29804.831349.369201@alkaid.it.uu.se> (raw)
In-Reply-To: <1100480985.7381.18.camel@localhost.localdomain>
Rusty Russell writes:
> On Thu, 2004-11-11 at 10:37 +0100, Mikael Pettersson wrote:
> > Part 3/4 of the perfctr interrupt fixes:
> ...
> > } control;
> > +#ifdef CONFIG_PERFCTR_INTERRUPT_SUPPORT
> > + unsigned int interrupts_masked;
> > +#endif
> > } ____cacheline_aligned;
> > static DEFINE_PER_CPU(struct per_cpu_cache, per_cpu_cache);
>
> While you're here, does this really have to be cacheline aligned? I
> wouldn't think so, since it's in the per-cpu section anyway.
The ____cacheline_aligned is a left-over from the [NR_CPUS] days;
it's probably not needed any more. I'll submit a patch to delete
it and also move the interrupts_masked field nearer the head of the
struct (to reduce # of cache lines touched in the common case).
/Mikael
prev parent reply other threads:[~2004-11-15 9:22 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2004-11-11 9:37 Mikael Pettersson
2004-11-15 1:09 ` Rusty Russell
2004-11-15 9:18 ` Mikael Pettersson [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=16792.29804.831349.369201@alkaid.it.uu.se \
--to=mikpe@csd.uu.se \
--cc=akpm@osdl.org \
--cc=linux-kernel@vger.kernel.org \
--cc=rusty@rustcorp.com.au \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®