From: patchwork-bot+netdevbpf@kernel.org
To: Maxim Korotkov <korotkov.maxim.s@gmail.com>
Cc: rmody@marvell.com, GR-Linux-NIC-Dev@marvell.com,
davem@davemloft.net, edumazet@google.com, kuba@kernel.org,
pabeni@redhat.com, mchan@broadcom.com, vadim.fedorenko@linux.dev,
netdev@vger.kernel.org, linux-kernel@vger.kernel.org,
lvc-project@linuxtesting.org, leonro@nvidia.com
Subject: Re: [PATCH net-next v2] bnx2: remove deadcode in bnx2_init_cpus()
Date: Fri, 24 Mar 2023 05:00:26 +0000 [thread overview]
Message-ID: <167963402673.21241.18025874959684415951.git-patchwork-notify@kernel.org> (raw)
In-Reply-To: <20230322162843.3452-1-korotkov.maxim.s@gmail.com>
Hello:
This patch was applied to netdev/net-next.git (main)
by Jakub Kicinski <kuba@kernel.org>:
On Wed, 22 Mar 2023 19:28:43 +0300 you wrote:
> The load_cpu_fw function has no error return code
> and always returns zero. Checking the value returned by
> this function does not make sense.
> Now checking the value of the return value is misleading when reading
> the code. Path with error handling was deleted in 57579f7629a3
> ("bnx2: Use request_firmware()").
> As a result, bnx2_init_cpus() will also return only zero
> Therefore, it will be safe to change the type of functions
> to void and remove checking to improving readability.
>
> [...]
Here is the summary with links:
- [net-next,v2] bnx2: remove deadcode in bnx2_init_cpus()
https://git.kernel.org/netdev/net-next/c/4691720f509a
You are awesome, thank you!
--
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html
prev parent reply other threads:[~2023-03-24 5:00 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-03-22 16:28 Maxim Korotkov
2023-03-24 5:00 ` patchwork-bot+netdevbpf [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=167963402673.21241.18025874959684415951.git-patchwork-notify@kernel.org \
--to=patchwork-bot+netdevbpf@kernel.org \
--cc=GR-Linux-NIC-Dev@marvell.com \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=korotkov.maxim.s@gmail.com \
--cc=kuba@kernel.org \
--cc=leonro@nvidia.com \
--cc=linux-kernel@vger.kernel.org \
--cc=lvc-project@linuxtesting.org \
--cc=mchan@broadcom.com \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=rmody@marvell.com \
--cc=vadim.fedorenko@linux.dev \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®