mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Rob Herring <robh@kernel.org>
To: Bharat Bhushan <bbhushan2@marvell.com>
Cc: linux-kernel@vger.kernel.org, robh+dt@kernel.org,
	linux@roeck-us.net, krzysztof.kozlowski+dt@linaro.org,
	devicetree@vger.kernel.org, linux-watchdog@vger.kernel.org,
	wim@linux-watchdog.org
Subject: Re: [PATCH 1/2] dt-bindings: watchdog: marvell octeonTX2 GTI watchdog driver
Date: Fri, 24 Mar 2023 15:17:41 -0500	[thread overview]
Message-ID: <167968860240.2423272.17528725519300805146.robh@kernel.org> (raw)
In-Reply-To: <20230324145652.19221-1-bbhushan2@marvell.com>


On Fri, 24 Mar 2023 20:26:51 +0530, Bharat Bhushan wrote:
> Add binding documentation for the Marvell octeonTX2
> GTI watchdog driver.
> 
> Signed-off-by: Bharat Bhushan <bbhushan2@marvell.com>
> ---
>  .../watchdog/marvel-octeontx2-wdt.yaml        | 43 +++++++++++++++++++
>  1 file changed, 43 insertions(+)
>  create mode 100644 Documentation/devicetree/bindings/watchdog/marvel-octeontx2-wdt.yaml
> 

My bot found errors running 'make DT_CHECKER_FLAGS=-m dt_binding_check'
on your patch (DT_CHECKER_FLAGS is new in v5.13):

yamllint warnings/errors:
./Documentation/devicetree/bindings/watchdog/marvel-octeontx2-wdt.yaml:28:2: [warning] wrong indentation: expected 2 but found 1 (indentation)

dtschema/dtc warnings/errors:
/builds/robherring/dt-review-ci/linux/Documentation/devicetree/bindings/watchdog/marvel-octeontx2-wdt.example.dtb: watch-dog@802000040000: $nodename:0: 'watch-dog@802000040000' does not match '^(timer|watchdog)(@.*|-[0-9a-f])?$'
	From schema: /builds/robherring/dt-review-ci/linux/Documentation/devicetree/bindings/watchdog/marvel-octeontx2-wdt.yaml

doc reference errors (make refcheckdocs):

See https://patchwork.ozlabs.org/project/devicetree-bindings/patch/20230324145652.19221-1-bbhushan2@marvell.com

The base for the series is generally the latest rc1. A different dependency
should be noted in *this* patch.

If you already ran 'make dt_binding_check' and didn't see the above
error(s), then make sure 'yamllint' is installed and dt-schema is up to
date:

pip3 install dtschema --upgrade

Please check and re-submit after running the above command yourself. Note
that DT_SCHEMA_FILES can be set to your schema file to speed up checking
your schema. However, it must be unset to test all examples with your schema.


  parent reply	other threads:[~2023-03-24 20:17 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-03-24 14:56 Bharat Bhushan
2023-03-24 14:56 ` [PATCH 2/2] Watchdog: octeontx2: Add Pseudo-NMI " Bharat Bhushan
2023-03-24 21:04   ` Thomas Weißschuh
2023-04-13 10:20     ` [EXT] " Bharat Bhushan
2023-03-24 22:03   ` Guenter Roeck
2023-04-13 10:22     ` [EXT] " Bharat Bhushan
2023-03-26  8:40   ` kernel test robot
2023-03-24 20:17 ` Rob Herring [this message]
2023-03-24 20:34 ` [PATCH 1/2] dt-bindings: watchdog: marvell octeonTX2 " Rob Herring
2023-04-13 10:14   ` [EXT] " Bharat Bhushan

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=167968860240.2423272.17528725519300805146.robh@kernel.org \
    --to=robh@kernel.org \
    --cc=bbhushan2@marvell.com \
    --cc=devicetree@vger.kernel.org \
    --cc=krzysztof.kozlowski+dt@linaro.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-watchdog@vger.kernel.org \
    --cc=linux@roeck-us.net \
    --cc=robh+dt@kernel.org \
    --cc=wim@linux-watchdog.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®