Re: [PATCH] gpio: lp87565: Add support for GPIO

[Keerthy <j-keerthy@ti.com>]

On Monday 12 June 2017 07:34 PM, Linus Walleij wrote:
> On Sun, Jun 11, 2017 at 6:27 AM, Keerthy <j-keerthy@ti.com> wrote:
>> On Friday 09 June 2017 02:06 PM, Linus Walleij wrote:
> 
>>> If this IC has several function modes for the pins it should also
>>> be a pin controller... I know it is a lot of upfront code, but... it will
>>> benefit you in the long run. Is it really just these three pins?
>>>
>>> Maybe we should merge it into
>>> drivers/pinctrl/pinctrl-lp87565.c so that at least file placement does
>>> not become a problem later?
>>
>> No Linus. Only 2 modes. So went along the lines of
>> drivers/gpio/gpio-lp873x.c. If you are not okay with this. I can as well
>> remove this part.
> 
> It's fine. Sometimes implementing things strictly in very generic frameworks
> will become a burden because of unnecessary complexities.
> 
> Can you just document it with some comments so it is clear what
> is happening here and what the two modes are? And keep it like this
> otherwise.

Okay sure. I will do that in v2.

Thanks,
Keerthy

> 
> Yours,
> Linus Walleij
>