From: Paul Mackerras <paulus@samba.org>
To: dhowells@redhat.com
Cc: linux-kernel@vger.kernel.org, akpm@osdl.org
Subject: cachefs broken on ppc64
Date: Mon, 22 Nov 2004 10:24:31 +1100 [thread overview]
Message-ID: <16801.9135.264043.449911@cargo.ozlabs.ibm.com> (raw)
David,
I just tried compiling 2.6.10-rc2-mm2, and just for fun, I turned on
cachefs, and found out that cachefs won't build on ppc64. The problem
is that it is using xchg() on 16-bit quantities, which we don't
support on ppc (32 or 64). Is there a good reason why
cachefs_super.ujnl_serial has to be 16 bits rather than 32?
It worries me a bit that you are using xchg() so much, actually. It
feels like you are trying to be clever and do things without taking
any locks, but there are no memory barriers anywhere in fs/cachefs
that I could see. So I suspect it would have problems on SMP ppc64 or
ia64 systems, which have weak memory consistency. Or is there some
serialization at a higher level that saves you? (If so, why do you
need to use xchg()?)
Paul.
next reply other threads:[~2004-11-21 23:28 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2004-11-21 23:24 Paul Mackerras [this message]
2004-11-22 12:01 ` David Howells
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=16801.9135.264043.449911@cargo.ozlabs.ibm.com \
--to=paulus@samba.org \
--cc=akpm@osdl.org \
--cc=dhowells@redhat.com \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®