mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Vinod Polimera <quic_vpolimer@quicinc.com>
To: <dri-devel@lists.freedesktop.org>,
	<linux-arm-msm@vger.kernel.org>,
	<freedreno@lists.freedesktop.org>, <devicetree@vger.kernel.org>
Cc: Vinod Polimera <quic_vpolimer@quicinc.com>,
	<linux-kernel@vger.kernel.org>, <robdclark@gmail.com>,
	<dianders@chromium.org>, <swboyd@chromium.org>,
	<quic_kalyant@quicinc.com>, <dmitry.baryshkov@linaro.org>,
	<quic_khsieh@quicinc.com>, <quic_vproddut@quicinc.com>,
	<quic_bjorande@quicinc.com>, <quic_abhinavk@quicinc.com>,
	<quic_sbillaka@quicinc.com>
Subject: [PATCH v1 1/3] drm/msm/dpu: set dirty_fb flag while in self refresh mode
Date: Fri, 31 Mar 2023 19:28:32 +0530	[thread overview]
Message-ID: <1680271114-1534-2-git-send-email-quic_vpolimer@quicinc.com> (raw)
In-Reply-To: <1680271114-1534-1-git-send-email-quic_vpolimer@quicinc.com>

While in virtual terminal mode with PSR enabled, there will be
no atomic commits triggered without dirty_fb being set. This
will create a notion of no screen update. Allow atomic commit
when dirty_fb ioctl is issued, so that it can trigger a PSR exit
and shows update on the screen.

Reported-by: Bjorn Andersson <andersson@kernel.org>
Link: https://lore.kernel.org/all/20230326162723.3lo6pnsfdwzsvbhj@ripper/
Signed-off-by: Vinod Polimera <quic_vpolimer@quicinc.com>
---
 drivers/gpu/drm/msm/disp/dpu1/dpu_crtc.c | 3 +++
 1 file changed, 3 insertions(+)

diff --git a/drivers/gpu/drm/msm/disp/dpu1/dpu_crtc.c b/drivers/gpu/drm/msm/disp/dpu1/dpu_crtc.c
index ab636da..96f645e 100644
--- a/drivers/gpu/drm/msm/disp/dpu1/dpu_crtc.c
+++ b/drivers/gpu/drm/msm/disp/dpu1/dpu_crtc.c
@@ -1158,6 +1158,9 @@ static bool dpu_crtc_needs_dirtyfb(struct drm_crtc_state *cstate)
 	struct drm_crtc *crtc = cstate->crtc;
 	struct drm_encoder *encoder;
 
+	if (cstate->self_refresh_active)
+		return true;
+
 	drm_for_each_encoder_mask (encoder, crtc->dev, cstate->encoder_mask) {
 		if (dpu_encoder_get_intf_mode(encoder) == INTF_MODE_CMD) {
 			return true;
-- 
2.7.4


  reply	other threads:[~2023-03-31 13:59 UTC|newest]

Thread overview: 16+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-03-31 13:58 [PATCH v1 0/3] Fixes for PSR Vinod Polimera
2023-03-31 13:58 ` Vinod Polimera [this message]
2023-03-31 14:45   ` [PATCH v1 1/3] drm/msm/dpu: set dirty_fb flag while in self refresh mode Dmitry Baryshkov
2023-04-03 14:53     ` Vinod Polimera
2023-04-03 16:18     ` Dmitry Baryshkov
2023-04-05  1:43   ` Doug Anderson
2023-03-31 13:58 ` [PATCH v1 2/3] msm/disp/dpu: allow atomic_check in PSR usecase Vinod Polimera
2023-03-31 14:46   ` Dmitry Baryshkov
2023-04-05  1:43   ` Doug Anderson
2023-03-31 13:58 ` [PATCH v1 3/3] msm: skip the atomic commit of self refresh while PSR running Vinod Polimera
2023-03-31 14:58   ` Dmitry Baryshkov
2023-04-03 12:01     ` Vinod Polimera
2023-04-03 16:11       ` Dmitry Baryshkov
2023-05-19 16:42         ` Dmitry Baryshkov
2023-04-03 15:28   ` Dmitry Baryshkov
2023-04-05 11:38 ` [PATCH v1 0/3] Fixes for PSR Dmitry Baryshkov

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1680271114-1534-2-git-send-email-quic_vpolimer@quicinc.com \
    --to=quic_vpolimer@quicinc.com \
    --cc=devicetree@vger.kernel.org \
    --cc=dianders@chromium.org \
    --cc=dmitry.baryshkov@linaro.org \
    --cc=dri-devel@lists.freedesktop.org \
    --cc=freedreno@lists.freedesktop.org \
    --cc=linux-arm-msm@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=quic_abhinavk@quicinc.com \
    --cc=quic_bjorande@quicinc.com \
    --cc=quic_kalyant@quicinc.com \
    --cc=quic_khsieh@quicinc.com \
    --cc=quic_sbillaka@quicinc.com \
    --cc=quic_vproddut@quicinc.com \
    --cc=robdclark@gmail.com \
    --cc=swboyd@chromium.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®