From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 44E1FC761AF for ; Fri, 31 Mar 2023 14:51:52 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232983AbjCaOvu (ORCPT ); Fri, 31 Mar 2023 10:51:50 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:59132 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S233000AbjCaOvi (ORCPT ); Fri, 31 Mar 2023 10:51:38 -0400 Received: from ams.source.kernel.org (ams.source.kernel.org [IPv6:2604:1380:4601:e00::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 7AAC120620; Fri, 31 Mar 2023 07:51:18 -0700 (PDT) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ams.source.kernel.org (Postfix) with ESMTPS id 7A635B83025; Fri, 31 Mar 2023 14:51:14 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 1CF50C433EF; Fri, 31 Mar 2023 14:51:10 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1680274273; bh=D+XXgjf2UQtBlW5uI89248mmOKHwBzaPnjYvu6vzuVc=; h=Subject:From:In-Reply-To:References:To:Cc:Date:From; b=o+INfz7QFJPaGxF/SL2LEnvjN1sS3PcOs9l70p3f6JdyC4A4I94RlpwJKqEbSEf7d sK+a5MeZHB6d1x9R9FDUQjzuQ9k7/LZBozzjusvPqtatGcypef+sE3ge6jRUsoeW85 XVLd7YVpouIwn1vgHfR1ykVKb+S3MdQ/K4aIuh41xj98TjpMfWcD3xVLPXfiVUtWnZ Fhd3WX2nKmrCP3sn+NVWD/uXUaQU72qsjOpJpvNncCvcJvJcoJvrt9s1dc0pCAp6C8 laaoQK+v9c5QwTGhuKCa/6w0OS/55/jusbRs0CjCnDA6hsIR8Qkafl49Tt8ffpaXUg rXTT7+LRt2vXw== Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Subject: Re: [v2] wifi: rtlwifi: fix incorrect error codes in rtl_debugfs_set_write_rfreg() From: Kalle Valo In-Reply-To: <20230326053138.91338-1-harperchen1110@gmail.com> References: <20230326053138.91338-1-harperchen1110@gmail.com> To: Wei Chen Cc: pkshih@realtek.com, davem@davemloft.net, edumazet@google.com, kuba@kernel.org, pabeni@redhat.com, linux-wireless@vger.kernel.org, netdev@vger.kernel.org, linux-kernel@vger.kernel.org, Wei Chen User-Agent: pwcli/0.1.1-git (https://github.com/kvalo/pwcli/) Python/3.7.3 Message-ID: <168027426945.32751.18184826221598610178.kvalo@kernel.org> Date: Fri, 31 Mar 2023 14:51:10 +0000 (UTC) Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Wei Chen wrote: > If there is a failure during copy_from_user or user-provided data buffer > is invalid, rtl_debugfs_set_write_rfreg should return negative error code > instead of a positive value count. > > Fix this bug by returning correct error code. Moreover, the check of buffer > against null is removed since it will be handled by copy_from_user. > > Fixes: 610247f46feb ("rtlwifi: Improve debugging by using debugfs") > Signed-off-by: Wei Chen > Reviewed-by: Simon Horman Patch applied to wireless-next.git, thanks. 905a9241e4e8 wifi: rtlwifi: fix incorrect error codes in rtl_debugfs_set_write_rfreg() -- https://patchwork.kernel.org/project/linux-wireless/patch/20230326053138.91338-1-harperchen1110@gmail.com/ https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches