From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755313AbdLTOqF (ORCPT ); Wed, 20 Dec 2017 09:46:05 -0500 Received: from cloudserver094114.home.net.pl ([79.96.170.134]:61796 "EHLO cloudserver094114.home.net.pl" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753868AbdLTOqE (ORCPT ); Wed, 20 Dec 2017 09:46:04 -0500 From: "Rafael J. Wysocki" To: Joel Fernandes Cc: Peter Zijlstra , LKML , Srinivas Pandruvada , Len Brown , Viresh Kumar , Ingo Molnar , Juri Lelli , Patrick Bellasi , Chris Redpath , Steve Muckle , Dietmar Eggemann , Vincent Guittot , Morten Ramussen , Frederic Weisbecker , Thomas Gleixner , Saravana Kannan , Vikram Mulukutla , Rohit Jain , Atish Patra , Josef Bacik , Rik van Riel , EAS Dev Subject: Re: [PATCH RESEND] cpufreq: schedutil: Use idle_calls counter of the remote CPU Date: Wed, 20 Dec 2017 15:45:13 +0100 Message-ID: <1680359.YAEeiLAcPD@aspire.rjw.lan> In-Reply-To: References: <20171219174712.13806-1-joelaf@google.com> <20171219184811.campbfjw3plynurs@hirez.programming.kicks-ass.net> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tuesday, December 19, 2017 8:32:09 PM CET Joel Fernandes wrote: > On Tue, Dec 19, 2017 at 10:48 AM, Peter Zijlstra wrote: > > On Tue, Dec 19, 2017 at 09:47:12AM -0800, Joel Fernandes wrote: > >> Since the recent remote cpufreq callback work, its possible that a cpufreq > >> update is triggered from a remote CPU. For single policies however, the current > >> code uses the local CPU when trying to determine if the remote sg_cpu entered > >> idle or is busy. This is incorrect. To remedy this, compare with the nohz tick > >> idle_calls counter of the remote CPU. > >> > >> Acked-by: Viresh Kumar > >> Signed-off-by: Joel Fernandes > > > > Acked-by: Peter Zijlstra (Intel) > > Sweet! OK, so any chance to get a Fixes: tag for the patch? Thanks, Rafael