From: Kalle Valo <kvalo@kernel.org>
To: Armin Wolf <W_Armin@gmx.de>
Cc: stf_xl@wp.pl, helmut.schaa@googlemail.com, davem@davemloft.net,
edumazet@google.com, kuba@kernel.org, pabeni@redhat.com,
linux-wireless@vger.kernel.org, netdev@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] wifi: rt2x00: Fix memory leak when handling surveys
Date: Mon, 3 Apr 2023 13:44:36 +0000 (UTC) [thread overview]
Message-ID: <168052947454.11825.87565460565328943.kvalo@kernel.org> (raw)
In-Reply-To: <20230330215637.4332-1-W_Armin@gmx.de>
Armin Wolf <W_Armin@gmx.de> wrote:
> When removing a rt2x00 device, its associated channel surveys
> are not freed, causing a memory leak observable with kmemleak:
>
> unreferenced object 0xffff9620f0881a00 (size 512):
> comm "systemd-udevd", pid 2290, jiffies 4294906974 (age 33.768s)
> hex dump (first 32 bytes):
> 70 44 12 00 00 00 00 00 92 8a 00 00 00 00 00 00 pD..............
> 00 00 00 00 00 00 00 00 ab 87 01 00 00 00 00 00 ................
> backtrace:
> [<ffffffffb0ed858b>] __kmalloc+0x4b/0x130
> [<ffffffffc1b0f29b>] rt2800_probe_hw+0xc2b/0x1380 [rt2800lib]
> [<ffffffffc1a9496e>] rt2800usb_probe_hw+0xe/0x60 [rt2800usb]
> [<ffffffffc1ae491a>] rt2x00lib_probe_dev+0x21a/0x7d0 [rt2x00lib]
> [<ffffffffc1b3b83e>] rt2x00usb_probe+0x1be/0x980 [rt2x00usb]
> [<ffffffffc05981e2>] usb_probe_interface+0xe2/0x310 [usbcore]
> [<ffffffffb13be2d5>] really_probe+0x1a5/0x410
> [<ffffffffb13be5c8>] __driver_probe_device+0x78/0x180
> [<ffffffffb13be6fe>] driver_probe_device+0x1e/0x90
> [<ffffffffb13be972>] __driver_attach+0xd2/0x1c0
> [<ffffffffb13bbc57>] bus_for_each_dev+0x77/0xd0
> [<ffffffffb13bd2a2>] bus_add_driver+0x112/0x210
> [<ffffffffb13bfc6c>] driver_register+0x5c/0x120
> [<ffffffffc0596ae8>] usb_register_driver+0x88/0x150 [usbcore]
> [<ffffffffb0c011c4>] do_one_initcall+0x44/0x220
> [<ffffffffb0d6134c>] do_init_module+0x4c/0x220
>
> Fix this by freeing the channel surveys on device removal.
>
> Tested with a RT3070 based USB wireless adapter.
>
> Fixes: 5447626910f5 ("rt2x00: save survey for every channel visited")
> Signed-off-by: Armin Wolf <W_Armin@gmx.de>
> Reviewed-by: Simon Horman <simon.horman@corigine.com>
> Acked-by: Stanislaw Gruszka <stf_xl@wp.pl>
Patch applied to wireless-next.git, thanks.
cbef9a83c51d wifi: rt2x00: Fix memory leak when handling surveys
--
https://patchwork.kernel.org/project/linux-wireless/patch/20230330215637.4332-1-W_Armin@gmx.de/
https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches
prev parent reply other threads:[~2023-04-03 13:44 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-03-30 21:56 Armin Wolf
2023-03-31 15:17 ` Simon Horman
2023-04-01 10:47 ` Stanislaw Gruszka
2023-04-03 13:44 ` Kalle Valo [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=168052947454.11825.87565460565328943.kvalo@kernel.org \
--to=kvalo@kernel.org \
--cc=W_Armin@gmx.de \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=helmut.schaa@googlemail.com \
--cc=kuba@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-wireless@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=stf_xl@wp.pl \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®