From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-oa1-f52.google.com (mail-oa1-f52.google.com [209.85.160.52]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id CF5603E959F for ; Tue, 14 Apr 2026 15:48:12 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.160.52 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1776181696; cv=none; b=hLqVthD9woJe7sk4DszIg+xQGtxe70KxCF9atxFDJJXHNJnqW5AYhIWycDxOsNUr7M95+3SKTQJ/PohpjEe1fw7b3nEgh7I/OVDCULW/UyF8fcdZzNrPXFWVEF9QLPpAfBDRlYdl2nd/FInIRGAY58cz/hxFvk+EIijvK6vWn0c= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1776181696; c=relaxed/simple; bh=ikNeOhmOPowGIBwTP2RDR/ooE3V0oQJWo5zR1OOYVA8=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=WItD9dQCiVUXap6VmClROYDevGItOiHWAsmWwpNicKqpJvp5LSlJXnqvGoDGQ5tlprlHduW9/99NTKND3duJ1KoF3yjTvy5h+9mOzJapT/IJvisXR6saqZ1nEiBwXD0UI4eozQbRlqsfiyO+tRZswawRjGaCkJwfaJ/y+pcVc4o= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=baylibre.com; spf=pass smtp.mailfrom=baylibre.com; dkim=pass (2048-bit key) header.d=baylibre-com.20251104.gappssmtp.com header.i=@baylibre-com.20251104.gappssmtp.com header.b=pXmNRxtP; arc=none smtp.client-ip=209.85.160.52 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=baylibre.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=baylibre.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=baylibre-com.20251104.gappssmtp.com header.i=@baylibre-com.20251104.gappssmtp.com header.b="pXmNRxtP" Received: by mail-oa1-f52.google.com with SMTP id 586e51a60fabf-41576c5c01cso4328284fac.3 for ; Tue, 14 Apr 2026 08:48:12 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=baylibre-com.20251104.gappssmtp.com; s=20251104; t=1776181692; x=1776786492; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=i1qpwzTA4mcNAyi8583h1bBEahEbIPk2eqNHcWexf+0=; b=pXmNRxtP4DpCN3oDJYSdy5qpfIIxDDGaYMJKtcp1h/+fVgJfyhN/PJT+LwGDukXbGj sxOMYAdtPverLqtSSynz4HwvOmHhR7BhIndvuUvINUXpV6NyEIZGj3G1gMBjDHNq9dhE 6uIqmerQT7H9/FTx2a1AR3z5PRjpjT6VLc+PkjRAn/n+rGp+Wx8ZjaUzuNvi46/9OoVl IJOU7+S2uPB8HShlti08hyxW6pqIlbR1qsVWdTJlo/l6GnO8Dvcqen09nfzbLBNoWIIa wijDs+PDTgx0IzuGikpPYwpNxG1+8zqH+flZamX9Og5QAAD0t9bIM8cRTcJEMWK6fEpP aslg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1776181692; x=1776786492; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-gg:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=i1qpwzTA4mcNAyi8583h1bBEahEbIPk2eqNHcWexf+0=; b=mZGNaAQuPcUK23rR9jkZCxnpbwAUZ2aCU/ID5eRQASDUH3f8wUvA/qTcNrVqCxSGiD 6QzLKbRbbE2XI9KxphyxMOKeu2SC56tZntR5W3GSzqWwI47XyRs3ShQkbQwqqlsbe8BV 4Emuw52kFWi7Em5LLOZhrz4tzGQQxJ11qZGfCVme40+FLUgxwzYooagiP7B32ko15KP9 8rYNSak5RGKYA9QRat6/yse3JgW4uhgVaVeZIHvz5Ghvh42+SRq59fGR97329n7S8I5P xaVOHAMsqkUL12gkOxn9iW0VIygxbTB/zVgeCZo/6YjzALOR7E/lJZdZETL+5wI5JRm+ iMIQ== X-Forwarded-Encrypted: i=1; AFNElJ8zHEjRJiNwx34UWr1eqUJo1SgPTYm9LchBvhgzyge1cu2bFqliGZ0cyv5OtOTx4hWg5qcZt1VS1eiCAF8=@vger.kernel.org X-Gm-Message-State: AOJu0YyymlvVBNMAI1s8bC64sAEq2sqTtt9FUqhdzxNcN27JeVFsQYvQ ShjxPxEgoVELEMmLt2ymWl3alc2hy96qRJHSFHrXJYrz5cDZQ/Q0SdJaOyhCxW7TQ8g= X-Gm-Gg: AeBDievy6gU0AfV9Jnc79FPAVxk2RyyJsrl3TsxYKNSPEOaG/6roAjkgXnmAz+/Mvat cjjqHJiYXMsX/OyrRZeMFmPa+clxVX3S6n5rsWGk5GCIh7VHxDpbUbJH8Seng9cm7lRp6tx3XY1 pXwUORJg5+5zXwNJ7uij9Lfa0u6dx1vqp9QC4Nf8/MkV6V9Sin/8myWF/x96cWNrNO7iuqvO1dB dh+9eG/iBEVCjVEaGZiU3VkkSfkkIAw4es00UFsNNO58sWLX6SwaC5uaERnS/wmiM3mEzEKiaKT pxchLBgJCEdF9svT/H81sxFueoFyTazUzDNWA0BCTB9MyDv4kAEa9p5Ez9HPSQFMRq7aW1exs4/ eZR4haXivkBOdUr5g1yfnQInJQQ1uxR1npB0PbxT79F5gIxx96i7GQvKUfbreYYJCRWMVm+K/z7 Q9pIP20mOjTHqOWw7hZ5sE6qjBMd1U4EgOkXDdsbtjCWmJamOltVT2WWDH4J+OVCEGFJJllASID w== X-Received: by 2002:a05:6870:ac87:b0:41c:4c93:4234 with SMTP id 586e51a60fabf-423e113e7bcmr9431171fac.35.1776181691738; Tue, 14 Apr 2026 08:48:11 -0700 (PDT) Received: from ?IPV6:2600:8803:e7e4:500:5bfd:a817:5527:c417? ([2600:8803:e7e4:500:5bfd:a817:5527:c417]) by smtp.gmail.com with ESMTPSA id 586e51a60fabf-423dd42130dsm11757546fac.8.2026.04.14.08.48.10 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 14 Apr 2026 08:48:11 -0700 (PDT) Message-ID: <16816b5d-2316-43be-99ca-6b54d4326371@baylibre.com> Date: Tue, 14 Apr 2026 10:48:10 -0500 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH 2/2] iio: dac: mcp47feb02: add MCP48FEB02 SPI driver to MCP47FEB02 I2C driver To: Ariana.Lazar@microchip.com, robh@kernel.org, krzk+dt@kernel.org, jic23@kernel.org, nuno.sa@analog.com, conor+dt@kernel.org, andy@kernel.org Cc: Jonathan.Cameron@huawei.com, Conor.Dooley@microchip.com, devicetree@vger.kernel.org, linux-iio@vger.kernel.org, linux-kernel@vger.kernel.org References: <20260403-mcp47feb02-fix2-v1-0-da60c773550e@microchip.com> <20260403-mcp47feb02-fix2-v1-2-da60c773550e@microchip.com> <1e05b8f9-e95e-458d-9179-ac8268023ae5@baylibre.com> <4b289795ffe7ce3505087446a5f2aee053ace561.camel@microchip.com> Content-Language: en-US From: David Lechner In-Reply-To: <4b289795ffe7ce3505087446a5f2aee053ace561.camel@microchip.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit On 4/14/26 10:28 AM, Ariana.Lazar@microchip.com wrote: > Hi David, > >>> --- a/drivers/iio/dac/Makefile >>> +++ b/drivers/iio/dac/Makefile >>> @@ -54,6 +54,9 @@ obj-$(CONFIG_MAX5821) += max5821.o >>>  obj-$(CONFIG_MCP4725) += mcp4725.o >>>  obj-$(CONFIG_MCP4728) += mcp4728.o >>>  obj-$(CONFIG_MCP47FEB02) += mcp47feb02.o >> >> Shouldn't we be removing this old file? >> >> The patch series would be eaiser to understand if it was split into >> one commit to split the existing driver into two files and then >> another commit to add support for the new parts. >> >> >>> +mcp47feb02-objs := mcp47feb02-core.o Ah, I missed this line. >>> +obj-$(CONFIG_MCP47FEB02_I2C) += mcp47feb02-i2c.o >>> +obj-$(CONFIG_MCP47FEB02_SPI) += mcp47feb02-spi.o >>>  obj-$(CONFIG_MCP4821) += mcp4821.o >>>  obj-$(CONFIG_MCP4922) += mcp4922.o >>>  obj-$(CONFIG_STM32_DAC_CORE) += stm32-dac-core.o >> > > Thank you for the review. > > I kept that line so the core module would compile as 'mcp47feb02.ko'. > If you prefer, I can rename the core file to mcp47feb02.c and add just > the lines for the SPI and I2C modules in the Makefile. It looks like there is only a few other driver that implement it the way you have. And only a few others that don't have "core" in the C file name. > > Another option would be to keep the core module named mcp47feb02-core.c > and compile it as 'mcp47feb02-core.ko'. It looks like this is the option most other drivers go with. So unless there is a good reason to do otherwise, I would tend to go with the most common pattern. > > Best regards, > Ariana