From: Rob Herring <robh@kernel.org>
To: Judith Mendez <jm@ti.com>
Cc: Jakub Kicinski <kuba@kernel.org>, Nishanth Menon <nm@ti.com>,
Rob Herring <robh+dt@kernel.org>, Paolo Abeni <pabeni@redhat.com>,
Chandrasekar Ramakrishnan <rcsekar@samsung.com>,
devicetree@vger.kernel.org,
Oliver Hartkopp <socketcan@hartkopp.net>,
linux-can@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
Eric Dumazet <edumazet@google.com>,
Tero Kristo <kristo@kernel.org>, Schuyler Patton <spatton@ti.com>,
Wolfgang Grandegger <wg@grandegger.com>,
"David S . Miller" <davem@davemloft.net>,
Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
Marc Kleine-Budde <mkl@pengutronix.de>,
Vignesh Raghavendra <vigneshr@ti.com>,
netdev@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2 2/4] dt-bindings: net: can: Add poll-interval for MCAN
Date: Mon, 24 Apr 2023 19:13:16 -0500 [thread overview]
Message-ID: <168238155801.4123790.14706903991436332296.robh@kernel.org> (raw)
In-Reply-To: <20230424195402.516-3-jm@ti.com>
On Mon, 24 Apr 2023 14:54:00 -0500, Judith Mendez wrote:
> On AM62x SoC, MCANs on MCU domain do not have hardware interrupt
> routed to A53 Linux, instead they will use software interrupt by
> hrtimer. To enable timer method, interrupts should be optional so
> remove interrupts property from required section and introduce
> poll-interval property.
>
> Signed-off-by: Judith Mendez <jm@ti.com>
> ---
> Changelog:
> v2:
> 1. Add poll-interval property to enable timer polling method
> 2. Add example using poll-interval property
>
> .../bindings/net/can/bosch,m_can.yaml | 26 ++++++++++++++++---
> 1 file changed, 23 insertions(+), 3 deletions(-)
>
My bot found errors running 'make DT_CHECKER_FLAGS=-m dt_binding_check'
on your patch (DT_CHECKER_FLAGS is new in v5.13):
yamllint warnings/errors:
dtschema/dtc warnings/errors:
/builds/robherring/dt-review-ci/linux/Documentation/devicetree/bindings/net/can/bosch,m_can.yaml: 'example with interrupts' is not one of ['$id', '$schema', 'title', 'description', 'examples', 'required', 'allOf', 'anyOf', 'oneOf', 'definitions', '$defs', 'additionalProperties', 'dependencies', 'dependentRequired', 'dependentSchemas', 'patternProperties', 'properties', 'not', 'if', 'then', 'else', 'unevaluatedProperties', 'deprecated', 'maintainers', 'select', '$ref']
from schema $id: http://devicetree.org/meta-schemas/base.yaml#
/builds/robherring/dt-review-ci/linux/Documentation/devicetree/bindings/net/can/bosch,m_can.yaml: 'example with timer polling' is not one of ['$id', '$schema', 'title', 'description', 'examples', 'required', 'allOf', 'anyOf', 'oneOf', 'definitions', '$defs', 'additionalProperties', 'dependencies', 'dependentRequired', 'dependentSchemas', 'patternProperties', 'properties', 'not', 'if', 'then', 'else', 'unevaluatedProperties', 'deprecated', 'maintainers', 'select', '$ref']
from schema $id: http://devicetree.org/meta-schemas/base.yaml#
doc reference errors (make refcheckdocs):
See https://patchwork.ozlabs.org/project/devicetree-bindings/patch/20230424195402.516-3-jm@ti.com
The base for the series is generally the latest rc1. A different dependency
should be noted in *this* patch.
If you already ran 'make dt_binding_check' and didn't see the above
error(s), then make sure 'yamllint' is installed and dt-schema is up to
date:
pip3 install dtschema --upgrade
Please check and re-submit after running the above command yourself. Note
that DT_SCHEMA_FILES can be set to your schema file to speed up checking
your schema. However, it must be unset to test all examples with your schema.
next prev parent reply other threads:[~2023-04-25 0:13 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-04-24 19:53 [PATCH v2 0/4] Enable multiple MCAN on AM62x Judith Mendez
2023-04-24 19:53 ` [PATCH v2 1/4] can: m_can: Add hrtimer to generate software interrupt Judith Mendez
2023-04-24 20:14 ` Marc Kleine-Budde
2023-04-26 16:11 ` Mendez, Judith
2023-04-26 17:47 ` Marc Kleine-Budde
2023-05-01 16:03 ` Simon Horman
2023-04-24 19:54 ` [PATCH v2 2/4] dt-bindings: net: can: Add poll-interval for MCAN Judith Mendez
2023-04-24 20:17 ` Marc Kleine-Budde
2023-04-25 0:13 ` Rob Herring [this message]
2023-04-28 16:17 ` Mendez, Judith
2023-05-01 7:16 ` Krzysztof Kozlowski
2023-05-01 15:52 ` Mendez, Judith
2023-04-25 12:32 ` Nishanth Menon
2023-04-24 19:54 ` [PATCH v2 3/4] DO_NOT_MERGE arm64: dts: ti: Add AM62x MCAN MAIN domain transceiver overlay Judith Mendez
2023-04-25 12:47 ` Nishanth Menon
2023-05-01 15:54 ` Mendez, Judith
2023-04-24 19:54 ` [PATCH v2 4/4] DO_NOT_MERGE arm64: dts: ti: Enable MCU MCANs for AM62x Judith Mendez
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=168238155801.4123790.14706903991436332296.robh@kernel.org \
--to=robh@kernel.org \
--cc=davem@davemloft.net \
--cc=devicetree@vger.kernel.org \
--cc=edumazet@google.com \
--cc=jm@ti.com \
--cc=kristo@kernel.org \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=kuba@kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-can@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mkl@pengutronix.de \
--cc=netdev@vger.kernel.org \
--cc=nm@ti.com \
--cc=pabeni@redhat.com \
--cc=rcsekar@samsung.com \
--cc=robh+dt@kernel.org \
--cc=socketcan@hartkopp.net \
--cc=spatton@ti.com \
--cc=vigneshr@ti.com \
--cc=wg@grandegger.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®