From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 891242DCC04 for ; Wed, 3 Dec 2025 09:01:52 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=170.10.133.124 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1764752514; cv=none; b=LfeVeHd29rDz6DNS4Ubt/kuQwEjB5A8QYe3Ia2iKlnWdzpMyzL4wGdCl+oVWp1yB3hW0TsCEWrKXAlsSgcRWg7Uo1rAZkLzhiXlt0m1P/D0GbSzEoYy+Tpd32WwKF8pCMjxvUJJZK61Q6oU6mbfVMNfM6HcoD4CAfiqUyH5vAcE= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1764752514; c=relaxed/simple; bh=vIwUJ0goI0C1yxxERv1G3eCwXSERxKrEpSTSJJVAXIU=; h=From:In-Reply-To:References:To:Cc:Subject:MIME-Version: Content-Type:Date:Message-ID; b=Zt6YKWnNuLHGM1F9kCFRFqx9kfsKBlZV3i+4GkzWOYNaBHxe3pno5Lm6Xh+FTXu9LKKyPZy6TlJJOPY7UNwkgE+pW6nV93UR6qUFt5bLqsYPQ/iNibmB06YexBFTjck2v0sTGvJXCPEH8fA+21gPLUdK3V9vYgRKFBGTdb47uzA= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=redhat.com; spf=pass smtp.mailfrom=redhat.com; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b=CqjAwRB8; arc=none smtp.client-ip=170.10.133.124 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=redhat.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=redhat.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="CqjAwRB8" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1764752511; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=lv4nzr1Qaoy5VKC0VGHotmxyvcmCxUkHsPe1OGF9+6I=; b=CqjAwRB8nuoiDwSEbi8mOyMBUdwHQdy/qAGDoyB1OAFx2Cpcsdiq514z7la8XN210OwbcQ 35Drv2P523voq0Y+4x8gWr3LcAU6TndxV1QHwPNygpG8RZZNnj0hMTVVNXzw1yTasJ/mmJ 0Y/GxnBJrF/WABeSFOca5vNiOFwwdfA= Received: from mx-prod-mc-08.mail-002.prod.us-west-2.aws.redhat.com (ec2-35-165-154-97.us-west-2.compute.amazonaws.com [35.165.154.97]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-120-7GVZsr8WPAqCrCQfbqBWyg-1; Wed, 03 Dec 2025 04:01:23 -0500 X-MC-Unique: 7GVZsr8WPAqCrCQfbqBWyg-1 X-Mimecast-MFC-AGG-ID: 7GVZsr8WPAqCrCQfbqBWyg_1764752480 Received: from mx-prod-int-06.mail-002.prod.us-west-2.aws.redhat.com (mx-prod-int-06.mail-002.prod.us-west-2.aws.redhat.com [10.30.177.93]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mx-prod-mc-08.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTPS id 4C2A418001E8; Wed, 3 Dec 2025 09:01:20 +0000 (UTC) Received: from warthog.procyon.org.uk (unknown [10.42.28.14]) by mx-prod-int-06.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTP id 4B618180057E; Wed, 3 Dec 2025 09:01:16 +0000 (UTC) Organization: Red Hat UK Ltd. Registered Address: Red Hat UK Ltd, Amberley Place, 107-111 Peascod Street, Windsor, Berkshire, SI4 1TE, United Kingdom. Registered in England and Wales under Company Registration No. 3798903 From: David Howells In-Reply-To: <20251203072844.484893-3-ebiggers@kernel.org> References: <20251203072844.484893-3-ebiggers@kernel.org> <20251203072844.484893-1-ebiggers@kernel.org> To: Eric Biggers Cc: dhowells@redhat.com, linux-crypto@vger.kernel.org, Herbert Xu , Luis Chamberlain , Petr Pavlu , Daniel Gomez , Sami Tolvanen , "Jason A . Donenfeld" , Ard Biesheuvel , Stephan Mueller , Lukas Wunner , Ignat Korchagin , keyrings@vger.kernel.org, linux-modules@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v3 2/2] lib/crypto: tests: Add KUnit tests for ML-DSA verification Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-ID: <1682767.1764752475.1@warthog.procyon.org.uk> Content-Transfer-Encoding: quoted-printable Date: Wed, 03 Dec 2025 09:01:15 +0000 Message-ID: <1682768.1764752475@warthog.procyon.org.uk> X-Scanned-By: MIMEDefang 3.4.1 on 10.30.177.93 I'm seeing: ERROR: modpost: module mldsa_kunit uses symbol mldsa_use_hint from namesp= ace EXPORTED_FOR_KUNIT_TESTING, but does not import it. I have this in my .config: CONFIG_CRYPTO_LIB_MLDSA=3Dm CONFIG_CRYPTO_LIB_MLDSA_KUNIT_TEST=3Dm The problem appears to be here: #if IS_ENABLED(CONFIG_CRYPTO_LIB_MLDSA_KUNIT_TEST) /* Allow the __always_inline function use_hint() to be unit-tested. */ s32 mldsa_use_hint(u8 h, s32 r, s32 gamma2) { return use_hint(h, r, gamma2); } EXPORT_SYMBOL_IF_KUNIT(mldsa_use_hint); #endif It works if EXPORT_SYMBOL_IF_KUNIT() is changed to EXPORT_SYMBOL_GPL(). David