From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 2268BC77B75 for ; Fri, 5 May 2023 12:03:25 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232048AbjEEMDY (ORCPT ); Fri, 5 May 2023 08:03:24 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:56326 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232034AbjEEMDV (ORCPT ); Fri, 5 May 2023 08:03:21 -0400 Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id CD4E14ED3; Fri, 5 May 2023 05:03:20 -0700 (PDT) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id 69EB463D97; Fri, 5 May 2023 12:03:20 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id F32BDC433EF; Fri, 5 May 2023 12:03:16 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1683288199; bh=Ndf4luLTqs4g+H4PSvF6ERtG4AtnUUEJcgo5864W62E=; h=Subject:From:In-Reply-To:References:To:Cc:Date:From; b=SXZpN9CSSkf1w1OHnHLXuMwnio1laXiwGHsj8vus6U/oSpc6lMjTNSRxGHX4V31BI b4YbmBUfD26Bp9GaEAr8IM4n/oXjm2o03PqFy53u3e0ZSKd73sAs+z5rgFVzQlKJcB 0mIAa4tBT3ik4nG0i/gms3GNiODyglbVTKDtijqjrJzO7SCzbhYtkCtyUW8xH5D1HP jpV27RyuQkhKv99x/+PQGA9Ay/34YGZqm8AENDAzmn0KkNJw0JXiaXMLxRq5G2YlHy 3Q0mdnRAW7aBHBh6WxzLvqv4i6RQQBqRNNw59SZvIonXw4CeKdrWdMXDntjO4RaMJF pnyRcjQ2LMbbw== Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Subject: Re: [PATCH v2] wifi: mt7601u: delete dead code checking debugfs returns From: Kalle Valo In-Reply-To: <20230421092200.24456-1-wangjikai@hust.edu.cn> References: <20230421092200.24456-1-wangjikai@hust.edu.cn> To: Wang Jikai Cc: Jakub Kicinski , "David S. Miller" , Eric Dumazet , Paolo Abeni , Matthias Brugger , AngeloGioacchino Del Regno , hust-os-kernel-patches@googlegroups.com, Wang Jikai , linux-wireless@vger.kernel.org, netdev@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-mediatek@lists.infradead.org User-Agent: pwcli/0.1.1-git (https://github.com/kvalo/pwcli/) Python/3.7.3 Message-ID: <168328819522.30117.3097099418946262250.kvalo@kernel.org> Date: Fri, 5 May 2023 12:03:16 +0000 (UTC) Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Wang Jikai wrote: > Smatch reports that: > drivers/net/wireless/mediatek/mt7601u/debugfs.c:130 > mt7601u_init_debugfs() warn: 'dir' is an error pointer or valid". > > Debugfs code is not supposed to need error checking so instead of > changing this to if (IS_ERR()) the correct thing is to just delete > the dead code. > > Signed-off-by: Wang Jikai > Acked-by: Jakub Kicinski Patch applied to wireless-next.git, thanks. f3dc7bb037d8 wifi: mt7601u: delete dead code checking debugfs returns -- https://patchwork.kernel.org/project/linux-wireless/patch/20230421092200.24456-1-wangjikai@hust.edu.cn/ https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches