From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 0378CC77B7C for ; Thu, 11 May 2023 05:36:39 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S236684AbjEKFgh (ORCPT ); Thu, 11 May 2023 01:36:37 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:50674 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S236357AbjEKFga (ORCPT ); Thu, 11 May 2023 01:36:30 -0400 Received: from dfw.source.kernel.org (dfw.source.kernel.org [IPv6:2604:1380:4641:c500::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 5C7761BE; Wed, 10 May 2023 22:36:29 -0700 (PDT) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id D035764AC9; Thu, 11 May 2023 05:36:28 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 560E7C4339C; Thu, 11 May 2023 05:36:26 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1683783388; bh=Li8TsZIC3+G4sZ2u2PoC9+w39L+GRTcS+o1WoXz/ThI=; h=From:To:Cc:In-Reply-To:References:Subject:Date:From; b=UnXFj0rdh8DwN+JHlhLSnNxwfTgexUDqgGtNS2cNcZnsG0iTilDw2U7Kc+E7kwesT 5qLNXLTRDF7lAFiXSQEk9zbwp0BjGwkHrILyto4FlE9RfxzR7+Yr7k+IZgaBNOde5L Mzazg7ELqqbqEAo/PrmEq1jeXNhBMF63+6v7a10emFnHu961HtJZjdQP5dwqjjId40 2tG1qtH1h8m2sM5fll8XQnUtmbCqDqxIsh00yxT1eHBxBwSMHah+67Mt6wTYxdBUcP xwzrG8Jb6p2rvnpIwVE+useb2qy4QEvjvA2CtDSoQ4lWTQcTaEvoZgGhRGAOS9CyTl RxnvLyWAkAqqA== From: Mark Brown To: paul@crapouillou.net, Aidan MacDonald Cc: lgirdwood@gmail.com, perex@perex.cz, tiwai@suse.com, linux-mips@vger.kernel.org, alsa-devel@alsa-project.org, linux-kernel@vger.kernel.org In-Reply-To: <20230509125134.208129-1-aidanmacdonald.0x0@gmail.com> References: <20230509125134.208129-1-aidanmacdonald.0x0@gmail.com> Subject: Re: [PATCH v1] ASoC: jz4740-i2s: Make I2S divider calculations more robust Message-Id: <168378338586.323079.4615747574575722094.b4-ty@kernel.org> Date: Thu, 11 May 2023 14:36:25 +0900 MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit X-Mailer: b4 0.13-dev-bfdf5 Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, 09 May 2023 13:51:34 +0100, Aidan MacDonald wrote: > When the CPU supplies bit/frame clocks, the system clock (clk_i2s) > is divided to produce the bit clock. This is a simple 1/N divider > with a fairly limited range, so for a given system clock frequency > only a few sample rates can be produced. Usually a wider range of > sample rates is supported by varying the system clock frequency. > > The old calculation method was not very robust and could easily > produce the wrong clock rate, especially with non-standard rates. > For example, if the system clock is 1.99x the target bit clock > rate, the divider would be calculated as 1 instead of the more > accurate 2. > > [...] Applied to https://git.kernel.org/pub/scm/linux/kernel/git/broonie/sound.git for-next Thanks! [1/1] ASoC: jz4740-i2s: Make I2S divider calculations more robust commit: ad721bc919edfd8b4b06977458a412011e2f0c50 All being well this means that it will be integrated into the linux-next tree (usually sometime in the next 24 hours) and sent to Linus during the next merge window (or sooner if it is a bug fix), however if problems are discovered then the patch may be dropped or reverted. You may get further e-mails resulting from automated or manual testing and review of the tree, please engage with people reporting problems and send followup patches addressing any issues that are reported if needed. If any updates are required or you are submitting further changes they should be sent as incremental updates against current git, existing patches will not be replaced. Please add any relevant lists and maintainers to the CCs when replying to this mail. Thanks, Mark