mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Paul Moore <paul@paul-moore.com>
To: James Morris <jmorris@namei.org>
Cc: Linus Torvalds <torvalds@linux-foundation.org>,
	LSM List <linux-security-module@vger.kernel.org>,
	Linux Kernel Mailing List <linux-kernel@vger.kernel.org>
Subject: Re: [GIT PULL] SELinux list corruption fix for 3.18
Date: Wed, 15 Oct 2014 10:52:01 -0400	[thread overview]
Message-ID: <1684821.IaZ0PAoQZ3@sifl> (raw)
In-Reply-To: <alpine.LRH.2.11.1410151901560.11622@namei.org>

On Wednesday, October 15, 2014 07:05:55 PM James Morris wrote:
> On Wed, 15 Oct 2014, Linus Torvalds wrote:
> > On Wed, Oct 15, 2014 at 7:27 AM, Linus Torvalds
> > 
> > <torvalds@linux-foundation.org> wrote:
> > > No, the log is correct (the log always is, the back-merges can cause
> > > the trivial *diff* to be broken).
> > 
> > To add some details: the commits in there are
> > 
> >   f6ed66087648 Merge branch 'stable-3.18' of
> > 
> > git://git.infradead.org/users/pcmoore/selinux into f
> > 
> >   7c66bdc72bc3 selinux: fix inode security list corruption
> >   e7387395a07d selinux: normalize audit log formatting
> >   8497b78ecc9d selinux: cleanup error reporting in selinux_nlmsg_perm()
> >   6eb1ddc6bd3f selinux: make the netif cache namespace aware
> >   5e29532fed21 selinux: register nf hooks with single nf_register_hooks
> >   call
> >   82341ad9b962 selinux: fix a problem with IPv6 traffic denials in
> > 
> > selinux_ip_postroute()
> > 
> >   04e8d6ab1fa6 selinux: Permit bounded transitions under NO_NEW_PRIVS or
> >   NOSUID.> 
> > and all but the list corruption fix seem to just be duplicate commits
> > of things I have already gotten elsewhere. Somebody cherry-picking
> > commits and duplicating them?
> 
> Yep, I also already have these other changes under different commit IDs:
> 
> commit 7b0d0b40cd78cadb525df760ee4cac151533c2b5
> Author: Stephen Smalley <sds@tycho.nsa.gov>
> Date:   Mon Aug 4 13:36:49 2014 -0400
> 
>     selinux: Permit bounded transitions under NO_NEW_PRIVS or NOSUID.
> 
> 
> Paul: do you have the above commit ID in your tree?

It would seem I've got the Midas touch this merge window, my apologies yet 
again.

The short version is that everything should be fixed now, the stable-3.18 
branch should be the single list corruption patch on top of the next branch I 
sent previously.  James, could you please re-pull from the stable-3.18 branch?

Thanks for your patience.

The slightly longer version is that when I created the stable-3.18 branch from 
the next branch I used the '--clone' flag in stgit which updated the dates on 
the patches which were new for #next (not "committed" in stgit) and caused the 
commit IDs to change.  Another lesson learned, I'm sorry it caused additional 
problems.

-Paul

-- 
paul moore
www.paul-moore.com


      reply	other threads:[~2014-10-15 14:52 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-10-14 15:05 James Morris
2014-10-15  5:27 ` Linus Torvalds
2014-10-15  5:29   ` Linus Torvalds
2014-10-15  8:05     ` James Morris
2014-10-15 14:52       ` Paul Moore [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1684821.IaZ0PAoQZ3@sifl \
    --to=paul@paul-moore.com \
    --cc=jmorris@namei.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-security-module@vger.kernel.org \
    --cc=torvalds@linux-foundation.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®