From: Jens Axboe <axboe@kernel.dk>
To: tj@kernel.org, hch@lst.de, josef@toxicpanda.com,
Yu Kuai <yukuai1@huaweicloud.com>
Cc: cgroups@vger.kernel.org, linux-block@vger.kernel.org,
linux-kernel@vger.kernel.org, yukuai3@huawei.com,
yi.zhang@huawei.com, yangerkun@huawei.com
Subject: Re: [PATCH for-6.4/block] block/rq_qos: protect rq_qos apis with a new lock
Date: Tue, 23 May 2023 11:13:59 -0600 [thread overview]
Message-ID: <168486203985.398377.17593981162726402548.b4-ty@kernel.dk> (raw)
In-Reply-To: <20230414084008.2085155-1-yukuai1@huaweicloud.com>
On Fri, 14 Apr 2023 16:40:08 +0800, Yu Kuai wrote:
> commit 50e34d78815e ("block: disable the elevator int del_gendisk")
> move rq_qos_exit() from disk_release() to del_gendisk(), this will
> introduce some problems:
>
> 1) If rq_qos_add() is triggered by enabling iocost/iolatency through
> cgroupfs, then it can concurrent with del_gendisk(), it's not safe to
> write 'q->rq_qos' concurrently.
>
> [...]
Applied, thanks!
[1/1] block/rq_qos: protect rq_qos apis with a new lock
commit: a13bd91be22318768d55470cbc0b0f4488ef9edf
Best regards,
--
Jens Axboe
prev parent reply other threads:[~2023-05-23 17:14 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-04-14 8:40 Yu Kuai
2023-04-23 8:15 ` Yu Kuai
2023-05-04 2:16 ` Yu Kuai
2023-05-22 20:59 ` Tejun Heo
2023-05-23 17:13 ` Jens Axboe [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=168486203985.398377.17593981162726402548.b4-ty@kernel.dk \
--to=axboe@kernel.dk \
--cc=cgroups@vger.kernel.org \
--cc=hch@lst.de \
--cc=josef@toxicpanda.com \
--cc=linux-block@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=tj@kernel.org \
--cc=yangerkun@huawei.com \
--cc=yi.zhang@huawei.com \
--cc=yukuai1@huaweicloud.com \
--cc=yukuai3@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®