From: "Rafael J. Wysocki" <rjw@rjwysocki.net>
To: Viresh Kumar <viresh.kumar@linaro.org>
Cc: Linux PM <linux-pm@vger.kernel.org>,
LKML <linux-kernel@vger.kernel.org>,
Srinivas Pandruvada <srinivas.pandruvada@linux.intel.com>
Subject: Re: [PATCH 3/4] cpufreq: Fix governor module removal race
Date: Thu, 23 Nov 2017 14:16:08 +0100 [thread overview]
Message-ID: <1684964.YkVv9kPgaH@aspire.rjw.lan> (raw)
In-Reply-To: <20171123040117.GE4084@vireshk-i7>
On Thursday, November 23, 2017 5:01:17 AM CET Viresh Kumar wrote:
> On 23-11-17, 01:29, Rafael J. Wysocki wrote:
> > From: Rafael J. Wysocki <rafael.j.wysocki@intel.com>
> >
> > It is possible to remove a cpufreq governor module after
> > cpufreq_parse_governor() has returned success in
> > store_scaling_governor() and before cpufreq_set_policy()
> > acquires a reference to it, because the governor list is
> > not protected during that period and nothing prevents the
> > governor from being unregistered then. The pointer to the
> > governor structure coming from cpufreq_parse_governor() may
> > become stale as a result of that.
> >
> > Prevent that from happening by acquiring an extra reference
> > to the governor module temporarily in cpufreq_parse_governor(),
> > under cpufreq_governor_mutex, and dropping it in
> > store_scaling_governor(), when cpufreq_set_policy() returns.
> >
> > Note that the second cpufreq_parse_governor() call site is fine,
> > because it only cares about the policy member of new_policy.
> >
> > Signed-off-by: Rafael J. Wysocki <rafael.j.wysocki@intel.com>
> > ---
> > drivers/cpufreq/cpufreq.c | 8 ++++++++
> > 1 file changed, 8 insertions(+)
> >
> > Index: linux-pm/drivers/cpufreq/cpufreq.c
> > ===================================================================
> > --- linux-pm.orig/drivers/cpufreq/cpufreq.c
> > +++ linux-pm/drivers/cpufreq/cpufreq.c
> > @@ -607,11 +607,13 @@ static int cpufreq_parse_governor(char *
> > if (cpufreq_driver->setpolicy) {
> > if (!strncasecmp(str_governor, "performance", CPUFREQ_NAME_LEN)) {
> > policy->policy = CPUFREQ_POLICY_PERFORMANCE;
> > + policy->governor = NULL;
> > return 0;
> > }
> >
> > if (!strncasecmp(str_governor, "powersave", CPUFREQ_NAME_LEN)) {
> > policy->policy = CPUFREQ_POLICY_POWERSAVE;
> > + policy->governor = NULL;
>
> Why are the above two changes required? policy->governor should always be NULL
> for setpolicy drivers anyway.
OK, I'll drop them.
Thanks,
Rafael
next prev parent reply other threads:[~2017-11-23 13:16 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-11-23 0:21 [PATCH 0/4] cpufreq: Cleanups and governor module removal race fix Rafael J. Wysocki
2017-11-23 0:23 ` [PATCH 1/4] cpufreq: Clean up cpufreq_parse_governor() Rafael J. Wysocki
2017-11-23 3:55 ` Viresh Kumar
2017-11-23 0:24 ` [PATCH 2/4] cpufreq: Pass policy pointer to cpufreq_parse_governor() Rafael J. Wysocki
2017-11-23 3:56 ` Viresh Kumar
2017-11-23 0:29 ` [PATCH 3/4] cpufreq: Fix governor module removal race Rafael J. Wysocki
2017-11-23 4:01 ` Viresh Kumar
2017-11-23 13:16 ` Rafael J. Wysocki [this message]
2017-11-23 13:27 ` [PATCH v2 " Rafael J. Wysocki
2017-11-28 2:38 ` Viresh Kumar
2017-11-23 0:30 ` [PATCH 4/4] cpufreq: Drop pointless return statement Rafael J. Wysocki
2017-11-23 4:01 ` Viresh Kumar
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1684964.YkVv9kPgaH@aspire.rjw.lan \
--to=rjw@rjwysocki.net \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pm@vger.kernel.org \
--cc=srinivas.pandruvada@linux.intel.com \
--cc=viresh.kumar@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®