mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Lorenzo Pieralisi <lpieralisi@kernel.org>
To: "Krzysztof Wilczyński" <kw@linux.com>,
	"Rob Herring" <robh@kernel.org>,
	"Bjorn Helgaas" <bhelgaas@google.com>,
	"Wei Yongjun" <weiyongjun1@huawei.com>,
	"Linus Walleij" <linus.walleij@linaro.org>,
	"Andrew Murray" <amurray@thegoodpenguin.co.uk>,
	"Junyan Ye" <yejunyan@hust.edu.cn>
Cc: Lorenzo Pieralisi <lpieralisi@kernel.org>,
	hust-os-kernel-patches@googlegroups.com,
	Dongliang Mu <dzm91@hust.edu.cn>,
	linux-pci@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v3] pci: controller: pci-ftpci100: Release the clock resources
Date: Mon, 29 May 2023 10:24:42 +0200	[thread overview]
Message-ID: <168534865675.10610.11781973164480184341.b4-ty@kernel.org> (raw)
In-Reply-To: <20230508043641.23807-1-yejunyan@hust.edu.cn>

On Mon, 08 May 2023 12:36:41 +0800, Junyan Ye wrote:
> Smatch reported:
> 1. drivers/pci/controller/pci-ftpci100.c:526 faraday_pci_probe() warn:
> 'clk' from clk_prepare_enable() not released on lines: 442,451,462,478,512,517.
> 2. drivers/pci/controller/pci-ftpci100.c:526 faraday_pci_probe() warn:
> 'p->bus_clk' from clk_prepare_enable() not released on lines: 451,462,478,512,517.
> 
> The clock resource is obtained by devm_clk_get(), and then
> clk_prepare_enable() makes the clock resource ready for use. After that,
> clk_disable_unprepare() should be called to release the clock resource
> when it is no longer needed. However, while doing some error handling
> in faraday_pci_probe(), clk_disable_unprepare() is not called to release
> clk and p->bus_clk before returning. These return lines are exactly 442,
> 451, 462, 478, 512, 517.
> 
> [...]

Applied to pci/ftpci100, thanks!

[1/1] pci: controller: pci-ftpci100: Release the clock resources
      https://git.kernel.org/pci/pci/c/c60738de85f4

Thanks,
Lorenzo

      parent reply	other threads:[~2023-05-29  8:24 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-05-08  4:36 Junyan Ye
2023-05-08  6:12 ` Linus Walleij
2023-05-08  6:59 ` Christophe JAILLET
2023-05-08 12:38   ` Linus Walleij
2023-05-29  8:24 ` Lorenzo Pieralisi [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=168534865675.10610.11781973164480184341.b4-ty@kernel.org \
    --to=lpieralisi@kernel.org \
    --cc=amurray@thegoodpenguin.co.uk \
    --cc=bhelgaas@google.com \
    --cc=dzm91@hust.edu.cn \
    --cc=hust-os-kernel-patches@googlegroups.com \
    --cc=kw@linux.com \
    --cc=linus.walleij@linaro.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-pci@vger.kernel.org \
    --cc=robh@kernel.org \
    --cc=weiyongjun1@huawei.com \
    --cc=yejunyan@hust.edu.cn \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®