From: Jens Axboe <axboe@kernel.dk>
To: hch@lst.de, dlemoal@kernel.org, quic_pragalla@quicinc.com,
Yu Kuai <yukuai1@huaweicloud.com>
Cc: linux-block@vger.kernel.org, linux-kernel@vger.kernel.org,
yukuai3@huawei.com, yi.zhang@huawei.com, yangerkun@huawei.com
Subject: Re: [PATCH] blk-ioc: protect ioc_destroy_icq() by 'queue_lock'
Date: Wed, 31 May 2023 10:21:13 -0600 [thread overview]
Message-ID: <168555007304.194776.14532611731698933970.b4-ty@kernel.dk> (raw)
In-Reply-To: <20230531073435.2923422-1-yukuai1@huaweicloud.com>
On Wed, 31 May 2023 15:34:35 +0800, Yu Kuai wrote:
> Currently, icq is tracked by both request_queue(icq->q_node) and
> task(icq->ioc_node), and ioc_clear_queue() from elevator exit is not
> safe because it can access the list without protection:
>
> ioc_clear_queue ioc_release_fn
> lock queue_lock
> list_splice
> /* move queue list to a local list */
> unlock queue_lock
> /*
> * lock is released, the local list
> * can be accessed through task exit.
> */
>
> [...]
Applied, thanks!
[1/1] blk-ioc: protect ioc_destroy_icq() by 'queue_lock'
commit: 2dea233fdc6a00e53bf2ee5cd4b6fca353fd81f8
Best regards,
--
Jens Axboe
next prev parent reply other threads:[~2023-05-31 16:21 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-05-31 7:34 Yu Kuai
2023-05-31 12:47 ` Christoph Hellwig
2023-05-31 16:21 ` Jens Axboe [this message]
2023-06-05 12:58 ` Yu Kuai
2023-06-05 16:52 ` Jens Axboe
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=168555007304.194776.14532611731698933970.b4-ty@kernel.dk \
--to=axboe@kernel.dk \
--cc=dlemoal@kernel.org \
--cc=hch@lst.de \
--cc=linux-block@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=quic_pragalla@quicinc.com \
--cc=yangerkun@huawei.com \
--cc=yi.zhang@huawei.com \
--cc=yukuai1@huaweicloud.com \
--cc=yukuai3@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®