From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 91C7BC77B7E for ; Fri, 2 Jun 2023 01:26:11 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S233267AbjFBB0K (ORCPT ); Thu, 1 Jun 2023 21:26:10 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:51058 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S233562AbjFBB0E (ORCPT ); Thu, 1 Jun 2023 21:26:04 -0400 Received: from mail-yb1-xb49.google.com (mail-yb1-xb49.google.com [IPv6:2607:f8b0:4864:20::b49]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 0C1081A5 for ; Thu, 1 Jun 2023 18:26:02 -0700 (PDT) Received: by mail-yb1-xb49.google.com with SMTP id 3f1490d57ef6-bb0d11a56abso2178860276.2 for ; Thu, 01 Jun 2023 18:26:02 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20221208; t=1685669161; x=1688261161; h=cc:to:from:subject:message-id:references:mime-version:in-reply-to :date:from:to:cc:subject:date:message-id:reply-to; bh=o2zvpikRFiidESnQoAb98e8aAicesYNJvb+G2l2BF/g=; b=LvLPgItUC1m2vG1zxwx8NcsugPhNkwqF6g1OaGTDaBGVxNMYClwnw6ELriaAeSjc9l iAU0GiMGlyM1DVQG3Cd0fxvR1Z4QDT0F2gQJnYDHEgsywzn6nEkCEAngEQtTCoqZUqCk fC2zFOefXnryglqLYXoSEx6TL7ez2tPIS1PIDDcrquuXgYbHpcO0RoTC6U2wNxnV2ykQ SnQOUaZMKE88C3fOmHxiethmrur/HDVkFcYPbtRkl1s39TUqjQ+m9yy/qHi2+5iCgCRj qemwqWlbDMSjP7FCoDvbkQ8MJSccf22197V/QF09PdmRDeOKn8LUiF/T2TYFk914dIXg V+ZA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1685669161; x=1688261161; h=cc:to:from:subject:message-id:references:mime-version:in-reply-to :date:x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=o2zvpikRFiidESnQoAb98e8aAicesYNJvb+G2l2BF/g=; b=jGEJixsfgR5m5uETXWef3yKXtwhIWwnsmTAOm9HjOJPPffNEE/C2jwD/kuK9fVDAhW Sg+zPuzNMOu1qi12bEawHmXKfagGEGFbWMvitBGSFJ6vFjDYx6F8KcaOHSVYb3Kyz9bc QrKRzWV2lIahqgBkfrIv4wKHJxglIKGP1XT33QkyAhQQ4kJMDkR2Hv/ABuTRmNgNhiRB NI4RJ491VU8tUi8H9e+9wZnyM28wItwTE7ECrdGezgSaC0M6geBJHiekG3AiY07nOVtY DabRvxxi+GIFc8L3Koe0kacHMOC6qmQC9EG1+qVZU9fU4ik2NEuz7B348n1ArG4qJMjy KzwQ== X-Gm-Message-State: AC+VfDxgjQzh1w+NiZ0VmFQoEBoDiY2EKvKs6VK1tRo3kxxqgEyb6TKL Lb9zUy9qHAZYO6iOd2fHYR2Z1RmU91I= X-Google-Smtp-Source: ACHHUZ7oRbIPG3pUuj3V13bZVGq/Q586X18lNtgJ8unT4k40YoOzluIGin6GSh2bZV+7HssODgwNOSB52lQ= X-Received: from zagreus.c.googlers.com ([fda3:e722:ac3:cc00:7f:e700:c0a8:5c37]) (user=seanjc job=sendgmr) by 2002:a25:b208:0:b0:ba7:1499:e202 with SMTP id i8-20020a25b208000000b00ba71499e202mr1073903ybj.7.1685669161265; Thu, 01 Jun 2023 18:26:01 -0700 (PDT) Date: Thu, 1 Jun 2023 18:25:45 -0700 In-Reply-To: <20230531155821.80590-1-jon@nutanix.com> Mime-Version: 1.0 References: <20230531155821.80590-1-jon@nutanix.com> X-Mailer: git-send-email 2.41.0.rc2.161.g9c6817b8e7-goog Message-ID: <168565441637.671278.11380888112695790771.b4-ty@google.com> Subject: Re: [PATCH] KVM: VMX: restore vmx_vmexit alignment From: Sean Christopherson To: Sean Christopherson , Paolo Bonzini , Thomas Gleixner , Ingo Molnar , Borislav Petkov , Dave Hansen , x86@kernel.org, "H. Peter Anvin" , Josh Poimboeuf , "Peter Zijlstra (Intel)" , kvm@vger.kernel.org, linux-kernel@vger.kernel.org, Jon Kohler Cc: Alexey Dobriyan Content-Type: text/plain; charset="utf-8" Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, 31 May 2023 11:58:21 -0400, Jon Kohler wrote: > Commit 8bd200d23ec4 ("KVM: VMX: Flatten __vmx_vcpu_run()") changed > vmx_vmexit from SYM_FUNC_START to SYM_INNER_LABEL, accidentally > removing 16 byte alignment as SYM_FUNC_START uses SYM_A_ALIGN and > SYM_INNER_LABEL does not. Josh mentioned [1] this was unintentional. > > Fix by changing to SYM_INNER_LABEL_ALIGN instead. > > [...] Applied to kvm-x86 vmx, thanks! [1/1] KVM: VMX: restore vmx_vmexit alignment https://github.com/kvm-x86/linux/commit/331f22976816 -- https://github.com/kvm-x86/linux/tree/next https://github.com/kvm-x86/linux/tree/fixes