From: Jens Axboe <axboe@kernel.dk>
To: linux-block@vger.kernel.org, Hou Tao <houtao@huaweicloud.com>
Cc: Bart Van Assche <bvanassche@acm.org>, Jan Kara <jack@suse.cz>,
Bagas Sanjaya <bagasdotme@gmail.com>,
Chaitanya Kulkarni <kch@nvidia.com>,
cgroups@vger.kernel.org, Tejun Heo <tj@kernel.org>,
Zefan Li <lizefan.x@bytedance.com>,
Johannes Weiner <hannes@cmpxchg.org>,
Jonathan Corbet <corbet@lwn.net>,
linux-kernel@vger.kernel.org, linux-doc@vger.kernel.org,
houtao1@huawei.com
Subject: Re: [PATCH v4] blk-ioprio: Introduce promote-to-rt policy
Date: Tue, 06 Jun 2023 22:27:02 -0600 [thread overview]
Message-ID: <168611202214.121141.17298993524876974749.b4-ty@kernel.dk> (raw)
In-Reply-To: <20230428074404.280532-1-houtao@huaweicloud.com>
On Fri, 28 Apr 2023 15:44:04 +0800, Hou Tao wrote:
> Since commit a78418e6a04c ("block: Always initialize bio IO priority on
> submit"), bio->bi_ioprio will never be IOPRIO_CLASS_NONE when calling
> blkcg_set_ioprio(), so there will be no way to promote the io-priority
> of one cgroup to IOPRIO_CLASS_RT, because bi_ioprio will always be
> greater than or equals to IOPRIO_CLASS_RT.
>
> It seems possible to call blkcg_set_ioprio() first then try to
> initialize bi_ioprio later in bio_set_ioprio(), but this doesn't work
> for bio in which bi_ioprio is already initialized (e.g., direct-io), so
> introduce a new promote-to-rt policy to promote the iopriority of bio to
> IOPRIO_CLASS_RT if the ioprio is not already RT.
>
> [...]
Applied, thanks!
[1/1] blk-ioprio: Introduce promote-to-rt policy
commit: ddf63516d8d37528dc6834c7f19b55084e956068
Best regards,
--
Jens Axboe
prev parent reply other threads:[~2023-06-07 4:30 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-04-28 7:44 Hou Tao
2023-04-28 7:36 ` Bagas Sanjaya
2023-05-08 12:08 ` Hou Tao
2023-05-23 6:48 ` Hou Tao
2023-06-07 4:13 ` Hou Tao
2023-06-07 4:27 ` Jens Axboe [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=168611202214.121141.17298993524876974749.b4-ty@kernel.dk \
--to=axboe@kernel.dk \
--cc=bagasdotme@gmail.com \
--cc=bvanassche@acm.org \
--cc=cgroups@vger.kernel.org \
--cc=corbet@lwn.net \
--cc=hannes@cmpxchg.org \
--cc=houtao1@huawei.com \
--cc=houtao@huaweicloud.com \
--cc=jack@suse.cz \
--cc=kch@nvidia.com \
--cc=linux-block@vger.kernel.org \
--cc=linux-doc@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=lizefan.x@bytedance.com \
--cc=tj@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®