From: Rob Herring <robh@kernel.org>
To: Tommaso Merciai <tomm.merciai@gmail.com>
Cc: "Krzysztof Kozlowski" <krzysztof.kozlowski+dt@linaro.org>,
"Liam Girdwood" <lgirdwood@gmail.com>,
"Michael Riesch" <michael.riesch@wolfvision.net>,
"Mark Brown" <broonie@kernel.org>,
michael.roeder@avnet.eu, martin.hecht@avnet.eu,
devicetree@vger.kernel.org, linux-kernel@vger.kernel.org,
"Hans Verkuil" <hverkuil@xs4all.nl>,
"Benjamin Mugnier" <benjamin.mugnier@foss.st.com>,
"Shawn Tu" <shawnx.tu@intel.com>,
"Sakari Ailus" <sakari.ailus@linux.intel.com>,
linux-media@vger.kernel.org,
"Marco Felsch" <m.felsch@pengutronix.de>,
"Linus Walleij" <linus.walleij@linaro.org>,
"Mauro Carvalho Chehab" <mchehab@kernel.org>,
"Rob Herring" <robh+dt@kernel.org>,
linuxfancy@googlegroups.com, jacopo.mondi@ideasonboard.com,
"Conor Dooley" <conor+dt@kernel.org>,
"Gerald Loacker" <gerald.loacker@wolfvision.net>,
"Nicholas Roth" <nicholas@rothemail.net>,
"Krzysztof Hałasa" <khalasa@piap.pl>,
laurent.pinchart@ideasonboard.com,
"Mikhail Rudenko" <mike.rudenko@gmail.com>
Subject: Re: [PATCH v4 2/3] media: dt-bindings: alvium: add document YAML binding
Date: Wed, 07 Jun 2023 08:20:44 -0600 [thread overview]
Message-ID: <168614764466.3072404.16058504735971429157.robh@kernel.org> (raw)
In-Reply-To: <20230607131936.382406-3-tomm.merciai@gmail.com>
On Wed, 07 Jun 2023 15:19:24 +0200, Tommaso Merciai wrote:
> Add documentation of device tree in YAML schema for the ALVIUM
> Camera from Allied Vision Inc.
>
> References:
> - https://www.alliedvision.com/en/products/embedded-vision-solutions
>
> Signed-off-by: Tommaso Merciai <tomm.merciai@gmail.com>
> Reviewed-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
> ---
> Changes since v1:
> - Fixed build error as suggested by RHerring bot
>
> Changes since v2:
> - Fixed License as suggested by KKozlowski/CDooley
> - Removed rotation property as suggested by CDooley/LPinchart
> - Fixed example node name as suggested by CDooley
> - Fixed title as suggested by LPinchart
> - Fixed compatible name as suggested by LPinchart
> - Removed clock as suggested by LPinchart
> - Removed gpios not as suggested by LPinchart
> - Renamed property name streamon-delay into alliedvision,lp2hs-delay-us
> - Fixed vendor prefix, unit append as suggested by KKozlowski
> - Fixed data-lanes
> - Fixed blank space + example indentation (from 6 -> 4 space) as suggested by KKozlowski
> - Dropped status into example as suggested by KKozlowski
> - Added vcc-ext-in supply as suggested by LPinchart
> - Dropped pinctrl into example as suggested by LPinchart
>
> Changes since v3:
> - Fixed vcc-ext-in-supply description as suggested by LPinchart
> - Fixed alliedvision,lp2hs-delay-us description as suggested by LPinchart
> - Added maximum to alliedvision,lp2hs-delay-us as suggested by LPinchart
> - Collected Reviewed-by tag from LPinchart
>
> .../media/i2c/alliedvision,alvium-csi2.yaml | 96 +++++++++++++++++++
> 1 file changed, 96 insertions(+)
> create mode 100644 Documentation/devicetree/bindings/media/i2c/alliedvision,alvium-csi2.yaml
>
My bot found errors running 'make DT_CHECKER_FLAGS=-m dt_binding_check'
on your patch (DT_CHECKER_FLAGS is new in v5.13):
yamllint warnings/errors:
dtschema/dtc warnings/errors:
./Documentation/devicetree/bindings/media/i2c/alliedvision,alvium-csi2.yaml: $id: relative path/filename doesn't match actual path or filename
expected: http://devicetree.org/schemas/media/i2c/alliedvision,alvium-csi2.yaml#
doc reference errors (make refcheckdocs):
See https://patchwork.ozlabs.org/project/devicetree-bindings/patch/20230607131936.382406-3-tomm.merciai@gmail.com
The base for the series is generally the latest rc1. A different dependency
should be noted in *this* patch.
If you already ran 'make dt_binding_check' and didn't see the above
error(s), then make sure 'yamllint' is installed and dt-schema is up to
date:
pip3 install dtschema --upgrade
Please check and re-submit after running the above command yourself. Note
that DT_SCHEMA_FILES can be set to your schema file to speed up checking
your schema. However, it must be unset to test all examples with your schema.
next prev parent reply other threads:[~2023-06-07 14:20 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-06-07 13:19 [PATCH v4 0/3] media: i2c: Add support for alvium camera Tommaso Merciai
2023-06-07 13:19 ` [PATCH v4 1/3] dt-bindings: vendor-prefixes: Add prefix alliedvision Tommaso Merciai
2023-06-07 13:19 ` [PATCH v4 2/3] media: dt-bindings: alvium: add document YAML binding Tommaso Merciai
2023-06-07 14:06 ` Laurent Pinchart
2023-06-07 14:19 ` Tommaso Merciai
2023-06-07 14:18 ` Krzysztof Kozlowski
2023-06-07 15:20 ` Tommaso Merciai
2023-06-07 16:11 ` Krzysztof Kozlowski
2023-06-07 19:38 ` Tommaso Merciai
2023-06-07 14:20 ` Rob Herring [this message]
2023-06-07 17:16 ` Conor Dooley
2023-06-07 19:49 ` Tommaso Merciai
2023-06-07 20:46 ` Conor Dooley
2023-06-07 13:19 ` [PATCH v4 3/3] media: i2c: Add support for alvium camera Tommaso Merciai
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=168614764466.3072404.16058504735971429157.robh@kernel.org \
--to=robh@kernel.org \
--cc=benjamin.mugnier@foss.st.com \
--cc=broonie@kernel.org \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=gerald.loacker@wolfvision.net \
--cc=hverkuil@xs4all.nl \
--cc=jacopo.mondi@ideasonboard.com \
--cc=khalasa@piap.pl \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=laurent.pinchart@ideasonboard.com \
--cc=lgirdwood@gmail.com \
--cc=linus.walleij@linaro.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-media@vger.kernel.org \
--cc=linuxfancy@googlegroups.com \
--cc=m.felsch@pengutronix.de \
--cc=martin.hecht@avnet.eu \
--cc=mchehab@kernel.org \
--cc=michael.riesch@wolfvision.net \
--cc=michael.roeder@avnet.eu \
--cc=mike.rudenko@gmail.com \
--cc=nicholas@rothemail.net \
--cc=robh+dt@kernel.org \
--cc=sakari.ailus@linux.intel.com \
--cc=shawnx.tu@intel.com \
--cc=tomm.merciai@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®