From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 07D33C7EE23 for ; Wed, 7 Jun 2023 17:30:52 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231926AbjFGRau (ORCPT ); Wed, 7 Jun 2023 13:30:50 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:34264 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231935AbjFGRab (ORCPT ); Wed, 7 Jun 2023 13:30:31 -0400 Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 604E4210C for ; Wed, 7 Jun 2023 10:30:26 -0700 (PDT) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id DFCE8641FD for ; Wed, 7 Jun 2023 17:30:25 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPS id 4F66FC433EF; Wed, 7 Jun 2023 17:30:25 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1686159025; bh=rMJ3ZHFNgdmlUuFM0xas0L1YWaRZl3xS0/0vxWWbySo=; h=Subject:From:Date:References:In-Reply-To:To:Cc:From; b=a2SiPzTR8J6pyrOsbeOb69AYtOBZmdC0ghJT8cV6J2ILLBxbTxW/qb7N5euoDTGQm Z9b6877HcuZCQBmtOwc5JSlt+iznnLD8XhQVTgXDgZrDQlDSkXOHQBX0fyqcuH8Gdl hnPonUmxhxXtTcRQ7lp0ev0lAW/+0/9HrijJnWU4BTmGMNzamvvr3Q0nfcWOW9wbqb fLkjJpYtveFZjYRlmfPCoUwZWaxccxkBU2FALAVNP+VurWZcv1TKButLIOdNwpUgSK C5fyYBEMMmtP/PtPSWSWg7NC55FqxyCSKREQC+jwMgnoQh+dGfH5Fty5a2IzUPCnLB ok7KLYWvaL3Qg== Received: from aws-us-west-2-korg-oddjob-1.ci.codeaurora.org (localhost.localdomain [127.0.0.1]) by aws-us-west-2-korg-oddjob-1.ci.codeaurora.org (Postfix) with ESMTP id 24B87E4D016; Wed, 7 Jun 2023 17:30:25 +0000 (UTC) Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Subject: Re: [f2fs-dev] [PATCH v2] f2fs: do more sanity check on inode From: patchwork-bot+f2fs@kernel.org Message-Id: <168615902514.7521.467509343163618820.git-patchwork-notify@kernel.org> Date: Wed, 07 Jun 2023 17:30:25 +0000 References: <20230531014055.3904072-1-chao@kernel.org> In-Reply-To: <20230531014055.3904072-1-chao@kernel.org> To: Chao Yu Cc: jaegeuk@kernel.org, linux-kernel@vger.kernel.org, linux-f2fs-devel@lists.sourceforge.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hello: This patch was applied to jaegeuk/f2fs.git (dev) by Jaegeuk Kim : On Wed, 31 May 2023 09:40:55 +0800 you wrote: > There are several issues in sanity_check_inode(): > - The code looks not clean, it checks extra_attr related condition > dispersively. > - It missed to check i_extra_isize w/ lower boundary > - It missed to check feature dependency: prjquota, inode_chksum, > inode_crtime, compression features rely on extra_attr feature. > - It's not necessary to check i_extra_isize due to it will only > be assigned to non-zero value if f2fs_has_extra_attr() is true > in do_read_inode(). > > [...] Here is the summary with links: - [f2fs-dev,v2] f2fs: do more sanity check on inode https://git.kernel.org/jaegeuk/f2fs/c/3ef38938753c You are awesome, thank you! -- Deet-doot-dot, I am a bot. https://korg.docs.kernel.org/patchwork/pwbot.html