From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id E05E1EB64D7 for ; Tue, 20 Jun 2023 05:28:22 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230317AbjFTF2V (ORCPT ); Tue, 20 Jun 2023 01:28:21 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:56306 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230129AbjFTF2R (ORCPT ); Tue, 20 Jun 2023 01:28:17 -0400 Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id B433D10D5 for ; Mon, 19 Jun 2023 22:28:16 -0700 (PDT) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id 30EA860E76 for ; Tue, 20 Jun 2023 05:28:16 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 1FF7BC433C8; Tue, 20 Jun 2023 05:28:14 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1687238895; bh=eNWP27pvXIx46K2ZRZJOmYQdCv6fMOEMtPM4l5DU/O4=; h=Date:From:Subject:To:Cc:References:In-Reply-To:From; b=fflj7R4/Z8BwkLWxoqlOrbwlGd2Csf6Vx3QQYvfnCmuIp4UA4xIH3OESJLN0ObjN3 rJfMsBfLe8zu0+EW/ODqg4HLPG1rOAyckdN57iYF5lDG9iUN/DArmO9/BuhBc9ewxR D0KUk2SotpwlIXHjWft6ac+t3hjKmMng1m3qWUCEPzOkJ6nL7IobTANtrcvnWIXdCz YQbqrskLb74hfzxbAVTQIfHeb/vvDa/4+rGBOGducTbV2TFLiGrJ2sqNKa8IvMZU4t LfAveFkpA8ADxY5LM8LzFav5GQ7SeVnzRjHzUiBSHpLc1bTYxvPx2idoxaqZrAErxw 2O6DxzMgc0SeA== Date: Tue, 20 Jun 2023 10:51:25 +0530 From: Naveen N Rao Subject: Re: [RFC PATCH v1 1/3] Revert "powerpc/bug: Provide better flexibility to WARN_ON/__WARN_FLAGS() with asm goto" To: Christophe Leroy , Josh Poimboeuf , Michael Ellerman , Nicholas Piggin , Peter Zijlstra , Sathvika Vasireddy Cc: linux-kernel@vger.kernel.org, linuxppc-dev@lists.ozlabs.org, "Aneesh Kumar K.V" References: <8dd72199549e76e0e9c2aba1c89d5fe2b0cb1663.1686922583.git.christophe.leroy@csgroup.eu> In-Reply-To: <8dd72199549e76e0e9c2aba1c89d5fe2b0cb1663.1686922583.git.christophe.leroy@csgroup.eu> MIME-Version: 1.0 User-Agent: astroid/0.16.0 (https://github.com/astroidmail/astroid) Message-Id: <1687237941.1wok7iiqm0.naveen@kernel.org> Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: quoted-printable Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Christophe Leroy wrote: > This reverts commit 1e688dd2a3d6759d416616ff07afc4bb836c4213. >=20 > That commit aimed at optimising the code around generation of > WARN_ON/BUG_ON but this leads to a lot of dead code erroneously > generated by GCC. >=20 > text data bss dec hex filename > 9551585 3627834 224376 13403795 cc8693 vmlinux.before > 9535281 3628358 224376 13388015 cc48ef vmlinux.after >=20 > Once this change is reverted, in a standard configuration (pmac32 + > function tracer) the text is reduced by 16k which is around 1.7% Aneesh recently reported a build failure due to the use of 'asm goto' in =20 WARN_ON(). We were able to root-cause it to the use of 'asm goto' with=20 two config options: CONFIG_CC_OPTIMIZE_FOR_SIZE and=20 CONFIG_DEBUG_SECTION_MISMATCH. Along with the issues we found with 'asm goto' during objtool=20 enablement, I think it might be better to disable it for now. Acked-by: Naveen N Rao - Naveen