From: Rob Herring <robh@kernel.org>
To: Sebastian Reichel <sebastian.reichel@collabora.com>
Cc: kernel@collabora.com, linux-rockchip@lists.infradead.org,
linux-kernel@vger.kernel.org,
"Conor Dooley" <conor+dt@kernel.org>,
linux-arm-kernel@lists.infradead.org,
"Lorenzo Pieralisi" <lpieralisi@kernel.org>,
"Heiko Stuebner" <heiko@sntech.de>,
"Bjorn Helgaas" <bhelgaas@google.com>,
"Jingoo Han" <jingoohan1@gmail.com>,
"Krzysztof Wilczyński" <kw@linux.com>,
"Shawn Lin" <shawn.lin@rock-chips.com>,
devicetree@vger.kernel.org, linux-pci@vger.kernel.org,
"Gustavo Pimentel" <gustavo.pimentel@synopsys.com>,
"Simon Xue" <xxm@rock-chips.com>,
"Krzysztof Kozlowski" <krzysztof.kozlowski+dt@linaro.org>
Subject: Re: [PATCH v1 1/4] dt-bindings: PCI: dwc: rockchip: Fix interrupt-names issue
Date: Tue, 20 Jun 2023 11:08:34 -0600 [thread overview]
Message-ID: <168728091385.3833618.8845528184695868032.robh@kernel.org> (raw)
In-Reply-To: <20230616170022.76107-2-sebastian.reichel@collabora.com>
On Fri, 16 Jun 2023 19:00:19 +0200, Sebastian Reichel wrote:
> The RK356x (and RK3588) have 5 ganged interrupts. For example the
> "legacy" interrupt combines "inta/intb/intc/intd" with a register
> providing the details.
>
> Currently the binding is not specifying these interrupts resulting
> in a bunch of errors for all rk356x boards using PCIe.
>
> Fix this by specifying the interrupts and add them to the example
> to prevent regressions.
>
> Signed-off-by: Sebastian Reichel <sebastian.reichel@collabora.com>
> ---
> .../bindings/pci/rockchip-dw-pcie.yaml | 18 ++++++++++++++++++
> .../devicetree/bindings/pci/snps,dw-pcie.yaml | 15 ++++++++++++++-
> 2 files changed, 32 insertions(+), 1 deletion(-)
>
Reviewed-by: Rob Herring <robh@kernel.org>
next prev parent reply other threads:[~2023-06-20 17:08 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-06-16 17:00 [PATCH v1 0/4] RK3588 PCIe2 support Sebastian Reichel
2023-06-16 17:00 ` [PATCH v1 1/4] dt-bindings: PCI: dwc: rockchip: Fix interrupt-names issue Sebastian Reichel
2023-06-20 17:08 ` Rob Herring [this message]
2023-06-27 12:27 ` Serge Semin
2023-06-27 13:48 ` Rob Herring
2023-06-27 14:19 ` Serge Semin
2023-07-13 16:47 ` Sebastian Reichel
2023-06-16 17:00 ` [PATCH v1 2/4] dt-bindings: PCI: dwc: rockchip: Add missing legacy-interrupt-controller Sebastian Reichel
2023-06-20 17:09 ` Rob Herring
2023-06-27 12:54 ` Serge Semin
2023-06-16 17:00 ` [PATCH v1 3/4] dt-bindings: PCI: dwc: rockchip: Update for RK3588 Sebastian Reichel
2023-06-20 17:21 ` Rob Herring
2023-06-27 13:15 ` Serge Semin
2023-06-16 17:00 ` [PATCH v1 4/4] arm64: dts: rockchip: rk3588: add PCIe2 support Sebastian Reichel
2023-06-17 11:08 ` Jonas Karlman
2023-06-17 7:39 ` [PATCH v1 0/4] RK3588 " Serge Semin
2023-06-26 19:32 ` Rob Herring
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=168728091385.3833618.8845528184695868032.robh@kernel.org \
--to=robh@kernel.org \
--cc=bhelgaas@google.com \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=gustavo.pimentel@synopsys.com \
--cc=heiko@sntech.de \
--cc=jingoohan1@gmail.com \
--cc=kernel@collabora.com \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=kw@linux.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pci@vger.kernel.org \
--cc=linux-rockchip@lists.infradead.org \
--cc=lpieralisi@kernel.org \
--cc=sebastian.reichel@collabora.com \
--cc=shawn.lin@rock-chips.com \
--cc=xxm@rock-chips.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®