From: Paul Mackerras <paulus@samba.org>
To: Linas Vepstas <linas@austin.ibm.com>
Cc: anton@samba.org, akpm@osdl.org, linuxppc64-dev@ozlabs.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] PPC64: EEH Recovery
Date: Wed, 19 Jan 2005 17:06:05 +1100 [thread overview]
Message-ID: <16877.63693.915740.385920@cargo.ozlabs.ibm.com> (raw)
In-Reply-To: <20050117201415.GA11505@austin.ibm.com>
Linas Vepstas writes:
> p.s. It was not clear to me if the EEH patch previously sent
> (6 January 2005, same subject line) will be wending its way into
> the main Torvalds kernel tree, or not. I hadn't really gotten
> confirmation one way or another.
I'm not really totally happy with it yet, on a number of fronts:
1. You're adding more PCI-specific stuff to the device_node struct,
which I don't like. I would prefer that the device_node tree
contains basically just what we get from OF, and that we have a
separate struct for storing ppc64-specific information for each PCI
device. Fixing that is outside the scope of your patch, though.
2. I don't see why the device nodes for the PCI subtree being reset
would go away, and thus I don't see the need for your eeh_cfg_tree
struct.
3. Is there a good reason why we can't use the assigned-addresses
property on the relevant device tree nodes to tell us what to set
the BARs to?
4. I think the 5 second sleep is quite bogus, and shows that we have
the flow of control wrong. In particular I think it should be a
userland write to a sysfs file that kicks off the restart process
rather than it just happening after 5 seconds. Anyway, what
process or thread is executing that 5 second sleep? Is it keventd
or something?
5. AFAICS userland will get an unplug notification for the device, but
nothing to indicate that is due to an EEH slot isolation event. I
think userland should be told about EEH events.
Regards,
Paul.
next prev parent reply other threads:[~2005-01-19 6:01 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2005-01-06 19:24 Linas Vepstas
2005-01-17 20:14 ` Linas Vepstas
2005-01-19 6:06 ` Paul Mackerras [this message]
2005-01-19 16:00 ` Nathan Fontenot
2005-01-20 22:39 ` Linas Vepstas
2005-01-21 2:50 ` Paul Mackerras
2005-01-20 22:48 ` Linas Vepstas
-- strict thread matches above, loose matches on Subject: below --
2004-11-17 23:52 Linas Vepstas
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=16877.63693.915740.385920@cargo.ozlabs.ibm.com \
--to=paulus@samba.org \
--cc=akpm@osdl.org \
--cc=anton@samba.org \
--cc=linas@austin.ibm.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linuxppc64-dev@ozlabs.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®