From: Jens Axboe <axboe@kernel.dk>
To: tj@kernel.org, josef@toxicpanda.com,
Jinke Han <hanjinke.666@bytedance.com>
Cc: cgroups@vger.kernel.org, linux-block@vger.kernel.org,
linux-kernel@vger.kernel.org, andrea.righi@canonical.com,
Muchun Song <muchun.song@linux.dev>
Subject: Re: [PATCH v3] blk-throttle: Fix io statistics for cgroup v1
Date: Sun, 25 Jun 2023 08:01:22 -0600 [thread overview]
Message-ID: <168770168286.14597.14477909506148885094.b4-ty@kernel.dk> (raw)
In-Reply-To: <20230507170631.89607-1-hanjinke.666@bytedance.com>
On Mon, 08 May 2023 01:06:31 +0800, Jinke Han wrote:
> After commit f382fb0bcef4 ("block: remove legacy IO schedulers"),
> blkio.throttle.io_serviced and blkio.throttle.io_service_bytes become
> the only stable io stats interface of cgroup v1, and these statistics
> are done in the blk-throttle code. But the current code only counts the
> bios that are actually throttled. When the user does not add the throttle
> limit, the io stats for cgroup v1 has nothing. I fix it according to the
> statistical method of v2, and made it count all ios accurately.
>
> [...]
Applied, thanks!
[1/1] blk-throttle: Fix io statistics for cgroup v1
commit: ad7c3b41e86b59943a903d23c7b037d820e6270c
Best regards,
--
Jens Axboe
prev parent reply other threads:[~2023-06-25 14:01 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-05-07 17:06 Jinke Han
2023-05-09 15:41 ` Tejun Heo
2023-05-11 6:38 ` Muchun Song
2023-06-25 4:50 ` hanjinke
2023-06-25 14:01 ` Jens Axboe [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=168770168286.14597.14477909506148885094.b4-ty@kernel.dk \
--to=axboe@kernel.dk \
--cc=andrea.righi@canonical.com \
--cc=cgroups@vger.kernel.org \
--cc=hanjinke.666@bytedance.com \
--cc=josef@toxicpanda.com \
--cc=linux-block@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=muchun.song@linux.dev \
--cc=tj@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®