From: bentiss@kernel.org
To: linux-input@vger.kernel.org, linux-kernel@vger.kernel.org,
Benjamin Tissoires <benjamin.tissoires@redhat.com>,
Jiri Kosina <jikos@kernel.org>,
Jason Gerecke <killertofu@gmail.com>
Cc: Benjamin Tissoires <bentiss@kernel.org>,
Ping Cheng <pinglinux@gmail.com>,
Aaron Armstrong Skomra <skomra@gmail.com>,
Joshua Dickens <Joshua@Joshua-Dickens.com>,
Peter Hutterer <peter.hutterer@who-t.net>,
Jason Gerecke <jason.gerecke@wacom.com>,
stable@vger.kernel.org
Subject: Re: [PATCH v2] HID: wacom: Use ktime_t rather than int when dealing with timestamps
Date: Mon, 26 Jun 2023 16:54:21 +0200 [thread overview]
Message-ID: <168779116662.356699.3703314952636539084.b4-ty@kernel.org> (raw)
In-Reply-To: <20230608213828.2108-1-jason.gerecke@wacom.com>
From: Benjamin Tissoires <bentiss@kernel.org>
On Thu, 08 Jun 2023 14:38:28 -0700, Jason Gerecke wrote:
> Code which interacts with timestamps needs to use the ktime_t type
> returned by functions like ktime_get. The int type does not offer
> enough space to store these values, and attempting to use it is a
> recipe for problems. In this particular case, overflows would occur
> when calculating/storing timestamps leading to incorrect values being
> reported to userspace. In some cases these bad timestamps cause input
> handling in userspace to appear hung.
>
> [...]
Updated the "from" email from your patch.
It would be nice if you could fix your workflow (I know you well enough
to know what is your gmail address, but not having to fix this by hand
would be preferable)
Applied to hid/hid.git (for-6.5/wacom), thanks!
[1/1] HID: wacom: Use ktime_t rather than int when dealing with timestamps
https://git.kernel.org/hid/hid/c/9a6c0e28e215
Cheers,
--
Benjamin Tissoires <bentiss@kernel.org>
prev parent reply other threads:[~2023-06-26 14:54 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-06-07 21:41 [PATCH] " Jason Gerecke
2023-06-08 2:51 ` Peter Hutterer
2023-06-08 13:35 ` kernel test robot
2023-06-08 14:26 ` kernel test robot
2023-06-08 21:38 ` [PATCH v2] " Jason Gerecke
2023-06-21 15:18 ` Jason Gerecke
2023-06-21 16:04 ` Benjamin Tissoires
2023-06-21 20:52 ` Jason Gerecke
2023-06-26 14:54 ` bentiss [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=168779116662.356699.3703314952636539084.b4-ty@kernel.org \
--to=bentiss@kernel.org \
--cc=Joshua@Joshua-Dickens.com \
--cc=benjamin.tissoires@redhat.com \
--cc=jason.gerecke@wacom.com \
--cc=jikos@kernel.org \
--cc=killertofu@gmail.com \
--cc=linux-input@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=peter.hutterer@who-t.net \
--cc=pinglinux@gmail.com \
--cc=skomra@gmail.com \
--cc=stable@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®