From: Bryan O'Donoghue <bryan.odonoghue@linaro.org>
To: Wenmeng Liu <quic_wenmliu@quicinc.com>,
Robert Foss <rfoss@kernel.org>, Todor Tomov <todor.too@gmail.com>,
Mauro Carvalho Chehab <mchehab@kernel.org>
Cc: linux-kernel@vger.kernel.org, linux-media@vger.kernel.org,
linux-arm-msm@vger.kernel.org
Subject: Re: [PATCH v2 1/3] media: qcom: camss: Add support for TPG common
Date: Fri, 15 Aug 2025 13:12:35 +0100 [thread overview]
Message-ID: <168788f0-4377-4b32-9730-23b2c4eca2a0@linaro.org> (raw)
In-Reply-To: <d4c0736b-5c17-4bce-86cf-6c0c48645667@quicinc.com>
On 15/08/2025 09:52, Wenmeng Liu wrote:
>>
>> Which clock is it we are setting here i.e. do we really need to care
>> about the rate at all ?
>
> TPG generally uses the clocks from CSIPHY/CSID/AON. If we can ensure
> that the clocks required by TPG are enabled in CSID/VFE, then there's no
> need to configure them in the TPG node.
>
> On Lemans (SA8775P), there's a special case where TPG requires the
> CAMNOC_AXI to be set to 400 MHz to function properly, while the sensor
> does not.
No that's fine.
The TPG should list the clocks _it_ depends on without assuming CSID or
VFE is running at all.
---
bod
next prev parent reply other threads:[~2025-08-15 12:12 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-07-17 3:20 [PATCH v2 0/3] media: qcom: camss: Add sa8775p camss TPG support Wenmeng Liu
2025-07-17 3:20 ` [PATCH v2 1/3] media: qcom: camss: Add support for TPG common Wenmeng Liu
2025-07-17 12:42 ` Bryan O'Donoghue
2025-08-15 8:52 ` Wenmeng Liu
2025-08-15 12:12 ` Bryan O'Donoghue [this message]
2025-07-17 12:43 ` Konrad Dybcio
2025-07-17 3:20 ` [PATCH v2 2/3] media: qcom: camss: Add link " Wenmeng Liu
2025-07-17 12:52 ` Konrad Dybcio
2025-07-17 12:56 ` Bryan O'Donoghue
2025-07-17 3:20 ` [PATCH v2 3/3] media: qcom: camss: tpg: Add TPG support for SA8775P Wenmeng Liu
2025-07-17 12:54 ` Konrad Dybcio
2025-07-17 12:59 ` Bryan O'Donoghue
2025-07-17 12:34 ` [PATCH v2 0/3] media: qcom: camss: Add sa8775p camss TPG support Konrad Dybcio
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=168788f0-4377-4b32-9730-23b2c4eca2a0@linaro.org \
--to=bryan.odonoghue@linaro.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-media@vger.kernel.org \
--cc=mchehab@kernel.org \
--cc=quic_wenmliu@quicinc.com \
--cc=rfoss@kernel.org \
--cc=todor.too@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®