From: Rob Herring <robh@kernel.org>
To: Nikita Bondarenko <n2h9z4@gmail.com>
Cc: linux@roeck-us.net, bcm-kernel-feedback-list@broadcom.com,
sbranden@broadcom.com, devicetree@vger.kernel.org,
wim@linux-watchdog.org, linux-watchdog@vger.kernel.org,
krzysztof.kozlowski+dt@linaro.org, f.fainelli@gmail.com,
robh+dt@kernel.org, rjui@broadcom.com,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH v3] dt-bindings: watchdog: brcm,kona-wdt: convert txt file to yaml
Date: Fri, 30 Jun 2023 11:16:41 -0600 [thread overview]
Message-ID: <168814537940.1984386.4796056831739397927.robh@kernel.org> (raw)
In-Reply-To: <20230418170341.28805-1-n2h9z4@gmail.com>
On Tue, 18 Apr 2023 19:03:41 +0200, Nikita Bondarenko wrote:
> Converted txt file to yaml. No additional changes.
>
> Signed-off-by: Nikita Bondarenko <n2h9z4@gmail.com>
> ---
>
> Changes in v3:
> - updated commit message
> - updated the compatible definition to probably fix "compatible is too long" warning
> - updated example to how it was in the txt file
>
>
> I do not have this warning when I am running
> make DT_SCHEMA_FILES=Documentation/devicetree/bindings/watchdog/brcm,kona-wdt.yaml ARCH=arm dt_binding_check
> maybe I run it without some additional variable?
>
> But I checked arch/arm/boot/dts/bcm28155-ap.dts, it includes bcm11351.dtsiv which contains
> compatible = "brcm,bcm11351-wdt", "brcm,kona-wdt";
> which probably causes a warning
> This is exact how it was in txt file example.
>
> If I put it in an example in a yaml file, dt_binding_check does not pass.
> Looks like the issue is in the enum type of compatible. It does not allow multiple strings.
> Updated to not to use enum. The example with two strings in compatible passes the checks.
>
> make DT_SCHEMA_FILES=Documentation/devicetree/bindings/watchdog/brcm,kona-wdt.yaml ARCH=arm dt_binding_check
> LINT Documentation/devicetree/bindings
> CHKDT Documentation/devicetree/bindings/processed-schema.json
> SCHEMA Documentation/devicetree/bindings/processed-schema.json
> DTEX Documentation/devicetree/bindings/watchdog/brcm,kona-wdt.example.dts
> DTC_CHK Documentation/devicetree/bindings/watchdog/brcm,kona-wdt.example.dtb
>
> make DT_SCHEMA_FILES=Documentation/devicetree/bindings/watchdog/brcm,kona-wdt.yaml ARCH=arm dtbs_check
> LINT Documentation/devicetree/bindings
> CHKDT Documentation/devicetree/bindings/processed-schema.json
> SCHEMA Documentation/devicetree/bindings/processed-schema.json
>
>
> v2 patch is here: https://patchwork.ozlabs.org/project/devicetree-bindings/patch/20230402135555.62507-1-n2h9z4@gmail.com/
>
> .../bindings/watchdog/brcm,kona-wdt.txt | 15 -------
> .../bindings/watchdog/brcm,kona-wdt.yaml | 41 +++++++++++++++++++
> 2 files changed, 41 insertions(+), 15 deletions(-)
> delete mode 100644 Documentation/devicetree/bindings/watchdog/brcm,kona-wdt.txt
> create mode 100644 Documentation/devicetree/bindings/watchdog/brcm,kona-wdt.yaml
>
Applied, thanks!
prev parent reply other threads:[~2023-06-30 17:17 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-04-18 17:03 Nikita Bondarenko
2023-04-21 18:34 ` Rob Herring
2023-04-24 16:53 ` Nikita B
2023-06-30 17:16 ` Rob Herring [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=168814537940.1984386.4796056831739397927.robh@kernel.org \
--to=robh@kernel.org \
--cc=bcm-kernel-feedback-list@broadcom.com \
--cc=devicetree@vger.kernel.org \
--cc=f.fainelli@gmail.com \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-watchdog@vger.kernel.org \
--cc=linux@roeck-us.net \
--cc=n2h9z4@gmail.com \
--cc=rjui@broadcom.com \
--cc=robh+dt@kernel.org \
--cc=sbranden@broadcom.com \
--cc=wim@linux-watchdog.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®