mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: "tip-bot2 for Peter Zijlstra" <tip-bot2@linutronix.de>
To: linux-tip-commits@vger.kernel.org
Cc: "Peter Zijlstra (Intel)" <peterz@infradead.org>,
	"Borislav Petkov (AMD)" <bp@alien8.de>,
	x86@kernel.org, linux-kernel@vger.kernel.org
Subject: [tip: objtool/urgent] iov_iter: Mark copy_iovec_from_user() noclone
Date: Mon, 10 Jul 2023 08:13:53 -0000	[thread overview]
Message-ID: <168897683354.404.11598434533900577662.tip-bot2@tip-bot2> (raw)
In-Reply-To: <20230616124354.GD4253@hirez.programming.kicks-ass.net>

The following commit has been merged into the objtool/urgent branch of tip:

Commit-ID:     719a937b7003933de1298ffa4b881dd6a234e244
Gitweb:        https://git.kernel.org/tip/719a937b7003933de1298ffa4b881dd6a234e244
Author:        Peter Zijlstra <peterz@infradead.org>
AuthorDate:    Fri, 16 Jun 2023 14:43:55 +02:00
Committer:     Peter Zijlstra <peterz@infradead.org>
CommitterDate: Mon, 10 Jul 2023 09:52:28 +02:00

iov_iter: Mark copy_iovec_from_user() noclone

Extend commit 50f9a76ef127 ("iov_iter: Mark
copy_compat_iovec_from_user() noinline") to also cover
copy_iovec_from_user(). Different compiler versions cause the same
problem on different functions.

lib/iov_iter.o: warning: objtool: .altinstr_replacement+0x1f: redundant UACCESS disable
lib/iov_iter.o: warning: objtool: iovec_from_user+0x84: call to copy_iovec_from_user.part.0() with UACCESS enabled
lib/iov_iter.o: warning: objtool: __import_iovec+0x143: call to copy_iovec_from_user.part.0() with UACCESS enabled

Fixes: 50f9a76ef127 ("iov_iter: Mark copy_compat_iovec_from_user() noinline")
Signed-off-by: Peter Zijlstra (Intel) <peterz@infradead.org>
Tested-by: Borislav Petkov (AMD) <bp@alien8.de>
Link: https://lkml.kernel.org/r/20230616124354.GD4253@hirez.programming.kicks-ass.net
---
 lib/iov_iter.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/lib/iov_iter.c b/lib/iov_iter.c
index b667b1e..e4dc809 100644
--- a/lib/iov_iter.c
+++ b/lib/iov_iter.c
@@ -1349,7 +1349,7 @@ uaccess_end:
 	return ret;
 }
 
-static int copy_iovec_from_user(struct iovec *iov,
+static __noclone int copy_iovec_from_user(struct iovec *iov,
 		const struct iovec __user *uiov, unsigned long nr_segs)
 {
 	int ret = -EFAULT;

  parent reply	other threads:[~2023-07-10  8:14 UTC|newest]

Thread overview: 21+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-03-27  1:00 linux-next: build warnings after merge of the block tree Stephen Rothwell
2023-03-27 16:26 ` Josh Poimboeuf
2023-03-27 23:47   ` Stephen Rothwell
2023-04-11 21:34     ` Stephen Rothwell
2023-04-11 21:55       ` Josh Poimboeuf
2023-04-11 22:39         ` Jens Axboe
2023-04-12  0:14           ` Josh Poimboeuf
2023-04-12  1:48             ` Jens Axboe
2023-04-12 11:44             ` Peter Zijlstra
2023-04-12 16:25               ` Josh Poimboeuf
2023-04-12 16:35                 ` Jens Axboe
2023-04-12 16:44                   ` Jens Axboe
2023-04-12 16:56                     ` Josh Poimboeuf
2023-04-12 17:57                       ` Jens Axboe
2023-06-16 12:43                 ` Peter Zijlstra
2023-06-16 12:49                   ` Borislav Petkov
2023-07-03 11:04                   ` Peter Zijlstra
2023-07-03 14:18                     ` Jens Axboe
2023-07-03 15:14                       ` Peter Zijlstra
2023-07-10  8:13                   ` tip-bot2 for Peter Zijlstra [this message]
2023-04-11 22:30       ` Jens Axboe

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=168897683354.404.11598434533900577662.tip-bot2@tip-bot2 \
    --to=tip-bot2@linutronix.de \
    --cc=bp@alien8.de \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-tip-commits@vger.kernel.org \
    --cc=peterz@infradead.org \
    --cc=x86@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®