From: Rob Herring <robh@kernel.org>
To: Stephan Gerhold <stephan@gerhold.net>
Cc: linux-arm-msm@vger.kernel.org,
"Otto Pflüger" <otto.pflueger@abscue.de>,
"Andy Gross" <agross@kernel.org>,
"Banajit Goswami" <bgoswami@quicinc.com>,
devicetree@vger.kernel.org,
"Krzysztof Kozlowski" <krzysztof.kozlowski+dt@linaro.org>,
"Konrad Dybcio" <konrad.dybcio@linaro.org>,
"Srinivas Kandagatla" <srinivas.kandagatla@linaro.org>,
alsa-devel@alsa-project.org, "Rob Herring" <robh+dt@kernel.org>,
"Mark Brown" <broonie@kernel.org>,
"Conor Dooley" <conor+dt@kernel.org>,
"Liam Girdwood" <lgirdwood@gmail.com>,
"Bjorn Andersson" <andersson@kernel.org>,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH 1/6] ASoC: dt-bindings: pm8916-analog-codec: Fix misleading example
Date: Wed, 19 Jul 2023 15:59:47 -0600 [thread overview]
Message-ID: <168980398687.852368.16225201877767633294.robh@kernel.org> (raw)
In-Reply-To: <20230718-pm8916-mclk-v1-1-4b4a58b4240a@gerhold.net>
On Tue, 18 Jul 2023 13:40:13 +0200, Stephan Gerhold wrote:
> SPMI devices typically have a single address cell and no size cell,
> i.e. reg = <0xf000> for the audio codec instead of reg = <0xf000 0x200>.
>
> The example is a bit misleading because it uses the latter. Copying
> this into the device tree would be incorrect and was fixed before for
> pm8916.dtsi in commit c2f0cbb57dba ("arm64: dts: qcom: pm8916: Remove
> invalid reg size from wcd_codec").
>
> Make the example more clear by adding the outer "pmic" node which
> specifies the same #address/size-cells that would be used in the
> real deivce tree.
>
> Signed-off-by: Stephan Gerhold <stephan@gerhold.net>
> ---
> .../sound/qcom,pm8916-wcd-analog-codec.yaml | 92 ++++++++++++----------
> 1 file changed, 50 insertions(+), 42 deletions(-)
>
Reviewed-by: Rob Herring <robh@kernel.org>
next prev parent reply other threads:[~2023-07-19 21:59 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-07-18 11:40 [PATCH 0/6] ASoC: codecs: msm8916-wcd-analog: Cleanup DT bindings Stephan Gerhold
2023-07-18 11:40 ` [PATCH 1/6] ASoC: dt-bindings: pm8916-analog-codec: Fix misleading example Stephan Gerhold
2023-07-19 21:59 ` Rob Herring [this message]
2023-07-18 11:40 ` [PATCH 2/6] ASoC: dt-bindings: pm8916-analog-codec: Drop pointless reg-names Stephan Gerhold
2023-07-19 22:00 ` Rob Herring
2023-07-18 11:40 ` [PATCH 3/6] ASoC: dt-bindings: pm8916-analog-codec: Drop invalid mclk Stephan Gerhold
2023-07-19 22:01 ` Rob Herring
2023-07-18 11:40 ` [PATCH 4/6] ASoC: codecs: msm8916-wcd-analog: " Stephan Gerhold
2023-07-18 11:40 ` [PATCH 5/6] ASoC: codecs: msm8916-wcd-analog: Properly handle probe errors Stephan Gerhold
2023-07-18 11:40 ` [PATCH 6/6] arm64: dts: qcom: pm8916: Drop codec reg-names and mclk Stephan Gerhold
2023-07-21 10:54 ` (subset) [PATCH 0/6] ASoC: codecs: msm8916-wcd-analog: Cleanup DT bindings Mark Brown
2023-09-20 17:14 ` Bjorn Andersson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=168980398687.852368.16225201877767633294.robh@kernel.org \
--to=robh@kernel.org \
--cc=agross@kernel.org \
--cc=alsa-devel@alsa-project.org \
--cc=andersson@kernel.org \
--cc=bgoswami@quicinc.com \
--cc=broonie@kernel.org \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=konrad.dybcio@linaro.org \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=lgirdwood@gmail.com \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=otto.pflueger@abscue.de \
--cc=robh+dt@kernel.org \
--cc=srinivas.kandagatla@linaro.org \
--cc=stephan@gerhold.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®