From: Jens Axboe <axboe@kernel.dk>
To: tj@kernel.org, josef@toxicpanda.com, chengming.zhou@linux.dev
Cc: cgroups@vger.kernel.org, linux-block@vger.kernel.org,
linux-kernel@vger.kernel.org, zhouchengming@bytedance.com
Subject: Re: [PATCH] blk-iocost: skip empty flush bio in iocost
Date: Thu, 20 Jul 2023 14:02:28 -0600 [thread overview]
Message-ID: <168988334811.126089.11961578901520630861.b4-ty@kernel.dk> (raw)
In-Reply-To: <20230720121441.1408522-1-chengming.zhou@linux.dev>
On Thu, 20 Jul 2023 20:14:41 +0800, chengming.zhou@linux.dev wrote:
> The flush bio may have data, may have no data (empty flush), we couldn't
> calculate cost for empty flush bio. So we'd better just skip it for now.
>
> Another side effect is that empty flush bio's bio_end_sector() is 0, cause
> iocg->cursor reset to 0, may break the cost calculation of other bios.
>
> This isn't good enough, since flush bio still consume the device bandwidth,
> but flush request is special, can be merged randomly in the flush state
> machine, we don't know how to calculate cost for it for now.
>
> [...]
Applied, thanks!
[1/1] blk-iocost: skip empty flush bio in iocost
commit: 013adcbef165c3eaf73e297b7482290593815ab8
Best regards,
--
Jens Axboe
prev parent reply other threads:[~2023-07-20 20:02 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-07-20 12:14 chengming.zhou
2023-07-20 19:59 ` Tejun Heo
2023-07-20 20:02 ` Jens Axboe [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=168988334811.126089.11961578901520630861.b4-ty@kernel.dk \
--to=axboe@kernel.dk \
--cc=cgroups@vger.kernel.org \
--cc=chengming.zhou@linux.dev \
--cc=josef@toxicpanda.com \
--cc=linux-block@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=tj@kernel.org \
--cc=zhouchengming@bytedance.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®