mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Tom Zanussi <zanussi@us.ibm.com>
To: Christoph Hellwig <hch@infradead.org>
Cc: Tom Zanussi <zanussi@us.ibm.com>,
	linux-kernel <linux-kernel@vger.kernel.org>,
	Greg KH <greg@kroah.com>, Andrew Morton <akpm@osdl.org>,
	Andi Kleen <ak@muc.de>, Roman Zippel <zippel@linux-m68k.org>,
	Robert Wisniewski <bob@watson.ibm.com>,
	Tim Bird <tim.bird@AM.SONY.COM>,
	karim@opersys.com
Subject: Re: [PATCH] relayfs redux, part 3
Date: Fri, 4 Feb 2005 16:06:58 -0600	[thread overview]
Message-ID: <16899.61954.289521.334673@tut.ibm.com> (raw)
In-Reply-To: <20050204213909.GA26241@infradead.org>

Christoph Hellwig writes:
 > in the filesystem path especially relayfs_create_entry and the functions
 > called by it seem overly complex, probably because copying from ramfs
 > which allows namespace operations from userland.  See the totally untested
 > code below for how it could be done more cleanly.

Thanks, I'll do some simplification as you suggest.

 > 
 > What I really dislike is the code for automatically creating complex
 > hiearchies.  What kinds of hierachies does LTT use?  It shouldn't be
 > more than subsystem/{stream1, stream2, ..., streamN}, right?  In that
 > case I think we could leave it to the user to take of that himself.
 > 

Yeah, I was debating whether to keep that code or just export a
creat_subdir() function instead, which I think I'll do after all.  ltt
doesn't really doesn't need much of a hierarchy beyond ltt/ or maybe
one more deep e.g. ltt/trace ltt/flight, and I doubt many other
applications would either.

Tom



  reply	other threads:[~2005-02-04 22:24 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2005-02-04 20:17 Tom Zanussi
2005-02-04 21:10 ` Christoph Hellwig
2005-02-04 22:00   ` Tom Zanussi
2005-02-04 21:39 ` Christoph Hellwig
2005-02-04 22:06   ` Tom Zanussi [this message]
2005-02-04 22:12 ` Andi Kleen
2005-02-04 22:22   ` Tom Zanussi
2005-02-05  6:57     ` Andi Kleen
2005-02-05  9:54 ` [PATCH] relayfs redux, part 3 II - another comment Andi Kleen

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=16899.61954.289521.334673@tut.ibm.com \
    --to=zanussi@us.ibm.com \
    --cc=ak@muc.de \
    --cc=akpm@osdl.org \
    --cc=bob@watson.ibm.com \
    --cc=greg@kroah.com \
    --cc=hch@infradead.org \
    --cc=karim@opersys.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=tim.bird@AM.SONY.COM \
    --cc=zippel@linux-m68k.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®